Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: warn when returning different hooks on subsequent renders #14585

Merged
merged 41 commits into from
Jan 22, 2019
Merged

RFC: warn when returning different hooks on subsequent renders #14585

Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
4d8a8cf
warn when returning different hooks on next render
Jan 14, 2019
0daee73
lint
Jan 14, 2019
623fb58
review changes
Jan 14, 2019
1204a0c
cleaner detection location
Jan 14, 2019
d597fcd
redundant comments
Jan 14, 2019
1c7314f
different EffectHook / LayoutEffectHook
Jan 14, 2019
5221e91
prettier
Jan 14, 2019
bcbce28
top level currentHookType
Jan 14, 2019
a604ea1
nulling currentHookType
Jan 14, 2019
8b22c87
small enhancements
Jan 17, 2019
95aa003
hook order checks for useContext/useImperative
Jan 17, 2019
cbf4068
Merge branch 'master' into wrong-hook-order
Jan 18, 2019
4676b6b
prettier
Jan 18, 2019
5a94b54
stray whitespace
Jan 18, 2019
aca87cd
move some bits around
Jan 18, 2019
428a3eb
better errors
Jan 18, 2019
6cd966c
pass tests
Jan 18, 2019
13debbb
lint, flow
Jan 18, 2019
65ebacb
Merge remote-tracking branch 'upstream/master' into wrong-hook-order
Jan 18, 2019
9bd7051
show a before - after diff
Jan 18, 2019
0eea976
Merge remote-tracking branch 'upstream/master' into wrong-hook-order
Jan 18, 2019
f09966d
an error stack in the warning
Jan 18, 2019
e366069
lose currentHookMatches, fix a test
Jan 19, 2019
d8c4236
tidy
Jan 19, 2019
4801b12
clear the mismatch only in dev
Jan 19, 2019
c77e448
pass flow
Jan 19, 2019
b6fb3ca
side by side diff
Jan 21, 2019
055ebf6
tweak warning
Jan 21, 2019
c7a872b
Merge remote-tracking branch 'upstream/master' into wrong-hook-order
Jan 21, 2019
e06b72b
pass flow
Jan 21, 2019
190e9b1
dedupe warnings per fiber, nits
Jan 21, 2019
f37f4fd
better format
Jan 21, 2019
26fd179
Merge remote-tracking branch 'upstream/master' into wrong-hook-order
Jan 21, 2019
3e8a217
nit
Jan 21, 2019
c2d686a
Merge remote-tracking branch 'upstream/master' into wrong-hook-order
Jan 21, 2019
f493675
fix bad merge, pass flow
Jan 22, 2019
a985e72
lint
Jan 22, 2019
1621a2d
missing hooktype enum
Jan 22, 2019
5ecda4c
merge currentHookType/currentHookNameInDev, fix nits
Jan 22, 2019
d4860ca
lint
Jan 22, 2019
3ad6523
final nits
Jan 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading