Code

Fix lazy() with defaultProps#14112

Code

Merged

gaearon merged 14 commits intofacebook:masterfacebook/react:masterfrom gaearon:lazy-fixgaearon/react:lazy-fixCopy head branch name to clipboardNov 6, 2018

+223-27

Commits

Commits on Nov 6, 2018

• Resolve defaultProps for Lazy components

  

  Brandon Dail

  authored and

  gaearon

  committed
  09b993e

  Copy full SHA for 09b993e

• Make test fail again

  

  Brandon Dail

  authored and

  gaearon

  committed
  baaceba

  Copy full SHA for baaceba

• Undo the partial fix

  gaearon

  committed
  34b3cb9

  Copy full SHA for 34b3cb9

• Make test output more compact

  gaearon

  committed
  94d1d17

  Copy full SHA for 94d1d17

• Add a separate failing test for sync mode

  gaearon

  committed
  89ec002

  Copy full SHA for 89ec002

• Clean up tests

  gaearon

  committed
  c0b2b6a

  Copy full SHA for c0b2b6a

• Add another update to both tests

  gaearon

  committed
  79151fb

  Copy full SHA for 79151fb

• Resolve props for commit phase lifecycles

  gaearon

  committed
  981d4dd

  Copy full SHA for 981d4dd

• Resolve prevProps for begin phase lifecycles

  gaearon

  committed
  b3db02d

  Copy full SHA for b3db02d

• Resolve prevProps for pre-commit lifecycles

  gaearon

  committed
  fb4a0c9

  Copy full SHA for fb4a0c9

• Only resolve props if element type differs

  gaearon

  committed
  a4acbf5

  Copy full SHA for a4acbf5

• Fix Flow

  gaearon

  committed
  344eb93

  Copy full SHA for 344eb93

• Don't set instance.props/state during commit phase

  Show description for 04417df
  gaearon

  committed
  04417df

  Copy full SHA for 04417df

• Keep setting instance.props/state before unmounting

  Show description for 40aeb2e
  gaearon

  committed
  40aeb2e

  Copy full SHA for 40aeb2e