Add a fallback component name for warnings #12429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Mar 22, 2018
| getComponentName(workInProgress), | ||
| ); | ||
| const state = instance.state; | ||
| if (state && (typeof state !== 'object' || isArray(state))) { |
There was a problem hiding this comment.
This is indentation change to make DEV-only intent clear (even though the whole function is only called in DEV).
But I also made it use name.
There was a problem hiding this comment.
https://github.com/facebook/react/pull/12429/files?w=1 without whitespace changes
bvaughn
approved these changes
Mar 22, 2018
LeonYuAng3NT
pushed a commit
to LeonYuAng3NT/react
that referenced
this pull request
Mar 22, 2018
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There used to be no fallback, leading to warnings like this for anonymous components:
This fixes them:
I tried writing a unit test but it's pretty annoying to reproduce without
createClass, and that has its own warnings so it gets a bit confusing. Issues like #12428 and #12427 also made writing tests a bit painful. I'm happy to revisit with a test when those are resolved.