Skip to content

Commit

Permalink
Don't reset error codes on CI build (#11655)
Browse files Browse the repository at this point in the history
* Don't reset error codes on CI build

* Add an explanation
  • Loading branch information
gaearon authored Nov 25, 2017
1 parent f0ba6bb commit d235e61
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion scripts/circleci/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
set -e

yarn build --extract-errors
git checkout -- scripts/error-codes/codes.json
# Note: since we run the full build including extracting error codes,
# it is important that we *don't* reset the change to `scripts/error-codes/codes.json`.
# When production bundle tests run later, it needs to be available.
# See https://github.com/facebook/react/pull/11655.

# Do a sanity check on bundles
node ./scripts/rollup/validate/index
Expand Down

0 comments on commit d235e61

Please sign in to comment.