Skip to content

Commit

Permalink
chore: remove devEngines declaration in root package (#32398)
Browse files Browse the repository at this point in the history
This change removes the `devEngines` declaration in the root package. It
didn't match the package.json spec and in npm 10.9.0 (released in
October), a breaking change was introduced that checks the `devEngines`
property. This causes `npm pack` calls to fail, due to the malformed
`devEngines`. Since there's already an `.nvmrc` defined in the repo, and
no strong need to enforce a specific node version for local development,
this removes the declaration altogether.
  • Loading branch information
michaelfaith authored Feb 16, 2025
1 parent 5adf402 commit be91130
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,6 @@
"web-streams-polyfill": "^3.1.1",
"yargs": "^15.3.1"
},
"devEngines": {
"node": "16.x || 18.x || 20.x || 22.x"
},
"jest": {
"testRegex": "/scripts/jest/dont-run-jest-directly\\.js$"
},
Expand All @@ -122,7 +119,7 @@
"lint": "node ./scripts/tasks/eslint.js",
"lint-build": "node ./scripts/rollup/validate/index.js",
"extract-errors": "node scripts/error-codes/extract-errors.js",
"postinstall": "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json && node ./scripts/flow/createFlowConfigs.js",
"postinstall": "node ./scripts/flow/createFlowConfigs.js",
"test": "node ./scripts/jest/jest-cli.js",
"test-stable": "node ./scripts/jest/jest-cli.js --release-channel=stable",
"test-www": "node ./scripts/jest/jest-cli.js --release-channel=www-modern",
Expand Down

0 comments on commit be91130

Please sign in to comment.