[compiler][be] Clean up bug test fixtures; evaluate more fixtures (#3…

…1812) Test fixtures testing different compiler features (e.g. non-auto memoization) should live in separate directories. Remove bug-prefixed fixtures that have since been fixed Add test evaluator export to more fixtures
facebook · Feb 18, 2025 · 86b1913 · 86b1913
1 parent a9575dc
commit 86b1913
Show file tree

Hide file tree

Showing 43 changed files with 664 additions and 139 deletions.
diff --git a/...bel-plugin-react-compiler/src/__tests__/fixtures/compiler/call-spread.expect.md b/...bel-plugin-react-compiler/src/__tests__/fixtures/compiler/call-spread.expect.md
@@ -2,22 +2,31 @@
 ## Input
 
 ```javascript
+import {makeArray} from 'shared-runtime';
+
 function Component(props) {
-  const x = foo(...props.a, null, ...props.b);
+  const x = makeArray(...props.a, null, ...props.b);
   return x;
 }
 
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{a: [1, 2], b: [2, 3, 4]}],
+};
+
 ```
 
 ## Code
 
 ```javascript
 import { c as _c } from "react/compiler-runtime";
+import { makeArray } from "shared-runtime";
+
 function Component(props) {
   const $ = _c(3);
   let t0;
   if ($[0] !== props.a || $[1] !== props.b) {
-    t0 = foo(...props.a, null, ...props.b);
+    t0 = makeArray(...props.a, null, ...props.b);
     $[0] = props.a;
     $[1] = props.b;
     $[2] = t0;
@@ -28,5 +37,12 @@ function Component(props) {
   return x;
 }
 
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{ a: [1, 2], b: [2, 3, 4] }],
+};
+
 ```
-      
+      
+### Eval output
+(kind: ok) [1,2,null,2,3,4]
diff --git a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/call-spread.js b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/call-spread.js
@@ -1,4 +1,11 @@
+import {makeArray} from 'shared-runtime';
+
 function Component(props) {
-  const x = foo(...props.a, null, ...props.b);
+  const x = makeArray(...props.a, null, ...props.b);
   return x;
 }
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{a: [1, 2], b: [2, 3, 4]}],
+};
diff --git a/...src/__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-2.expect.md b/...src/__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-2.expect.md
@@ -2,7 +2,9 @@
 ## Input
 
 ```javascript
-function component(foo, bar) {
+import {mutate} from 'shared-runtime';
+
+function Component({foo, bar}) {
   let x = {foo};
   let y = {bar};
   const f0 = function () {
@@ -15,14 +17,28 @@ function component(foo, bar) {
   return x;
 }
 
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{foo: 2, bar: 3}],
+  sequentialRenders: [
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 4},
+    {foo: 3, bar: 4},
+  ],
+};
+
 ```
 
 ## Code
 
 ```javascript
 import { c as _c } from "react/compiler-runtime";
-function component(foo, bar) {
+import { mutate } from "shared-runtime";
+
+function Component(t0) {
   const $ = _c(3);
+  const { foo, bar } = t0;
   let x;
   if ($[0] !== bar || $[1] !== foo) {
     x = { foo };
@@ -44,5 +60,21 @@ function component(foo, bar) {
   return x;
 }
 
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{ foo: 2, bar: 3 }],
+  sequentialRenders: [
+    { foo: 2, bar: 3 },
+    { foo: 2, bar: 3 },
+    { foo: 2, bar: 4 },
+    { foo: 3, bar: 4 },
+  ],
+};
+
 ```
-      
+      
+### Eval output
+(kind: ok) {"foo":2}
+{"foo":2}
+{"foo":2}
+{"foo":3}
diff --git a/...n-react-compiler/src/__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-2.js b/...n-react-compiler/src/__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-2.js
@@ -1,4 +1,6 @@
-function component(foo, bar) {
+import {mutate} from 'shared-runtime';
+
+function Component({foo, bar}) {
   let x = {foo};
   let y = {bar};
   const f0 = function () {
@@ -10,3 +12,14 @@ function component(foo, bar) {
   mutate(y);
   return x;
 }
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{foo: 2, bar: 3}],
+  sequentialRenders: [
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 4},
+    {foo: 3, bar: 4},
+  ],
+};
diff --git a/...__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-arr-2.expect.md b/...__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-arr-2.expect.md
@@ -2,7 +2,9 @@
 ## Input
 
 ```javascript
-function component(foo, bar) {
+import {mutate} from 'shared-runtime';
+
+function Component({foo, bar}) {
   let x = {foo};
   let y = {bar};
   const f0 = function () {
@@ -15,14 +17,28 @@ function component(foo, bar) {
   return x;
 }
 
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{foo: 2, bar: 3}],
+  sequentialRenders: [
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 4},
+    {foo: 3, bar: 4},
+  ],
+};
+
 ```
 
 ## Code
 
 ```javascript
 import { c as _c } from "react/compiler-runtime";
-function component(foo, bar) {
+import { mutate } from "shared-runtime";
+
+function Component(t0) {
   const $ = _c(3);
+  const { foo, bar } = t0;
   let x;
   if ($[0] !== bar || $[1] !== foo) {
     x = { foo };
@@ -44,5 +60,21 @@ function component(foo, bar) {
   return x;
 }
 
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{ foo: 2, bar: 3 }],
+  sequentialRenders: [
+    { foo: 2, bar: 3 },
+    { foo: 2, bar: 3 },
+    { foo: 2, bar: 4 },
+    { foo: 3, bar: 4 },
+  ],
+};
+
 ```
-      
+      
+### Eval output
+(kind: ok) {"foo":2}
+{"foo":2}
+{"foo":2}
+{"foo":3}
diff --git a/...act-compiler/src/__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-arr-2.js b/...act-compiler/src/__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-arr-2.js
@@ -1,4 +1,6 @@
-function component(foo, bar) {
+import {mutate} from 'shared-runtime';
+
+function Component({foo, bar}) {
   let x = {foo};
   let y = {bar};
   const f0 = function () {
@@ -10,3 +12,14 @@ function component(foo, bar) {
   mutate(y);
   return x;
 }
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{foo: 2, bar: 3}],
+  sequentialRenders: [
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 4},
+    {foo: 3, bar: 4},
+  ],
+};
diff --git a/.../__tests__/fixtures/compiler/capturing-func-alias-captured-mutate-arr.expect.md b/.../__tests__/fixtures/compiler/capturing-func-alias-captured-mutate-arr.expect.md
@@ -2,7 +2,8 @@
 ## Input
 
 ```javascript
-function component(foo, bar) {
+import {mutate} from 'shared-runtime';
+function Component({foo, bar}) {
   let x = {foo};
   let y = {bar};
   const f0 = function () {
@@ -15,14 +16,27 @@ function component(foo, bar) {
   return y;
 }
 
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{foo: 2, bar: 3}],
+  sequentialRenders: [
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 4},
+    {foo: 3, bar: 4},
+  ],
+};
+
 ```
 
 ## Code
 
 ```javascript
 import { c as _c } from "react/compiler-runtime";
-function component(foo, bar) {
+import { mutate } from "shared-runtime";
+function Component(t0) {
   const $ = _c(3);
+  const { foo, bar } = t0;
   let y;
   if ($[0] !== bar || $[1] !== foo) {
     const x = { foo };
@@ -44,5 +58,21 @@ function component(foo, bar) {
   return y;
 }
 
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{ foo: 2, bar: 3 }],
+  sequentialRenders: [
+    { foo: 2, bar: 3 },
+    { foo: 2, bar: 3 },
+    { foo: 2, bar: 4 },
+    { foo: 3, bar: 4 },
+  ],
+};
+
 ```
-      
+      
+### Eval output
+(kind: ok) {"bar":3,"wat0":"joe"}
+{"bar":3,"wat0":"joe"}
+{"bar":4,"wat0":"joe"}
+{"bar":4,"wat0":"joe"}
diff --git a/...eact-compiler/src/__tests__/fixtures/compiler/capturing-func-alias-captured-mutate-arr.js b/...eact-compiler/src/__tests__/fixtures/compiler/capturing-func-alias-captured-mutate-arr.js
@@ -1,4 +1,5 @@
-function component(foo, bar) {
+import {mutate} from 'shared-runtime';
+function Component({foo, bar}) {
   let x = {foo};
   let y = {bar};
   const f0 = function () {
@@ -10,3 +11,14 @@ function component(foo, bar) {
   mutate(y);
   return y;
 }
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{foo: 2, bar: 3}],
+  sequentialRenders: [
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 3},
+    {foo: 2, bar: 4},
+    {foo: 3, bar: 4},
+  ],
+};
diff --git a/.../src/__tests__/fixtures/compiler/capturing-func-alias-computed-mutate.expect.md b/.../src/__tests__/fixtures/compiler/capturing-func-alias-computed-mutate.expect.md
@@ -2,7 +2,8 @@
 ## Input
 
 ```javascript
-function component(a) {
+import {mutate} from 'shared-runtime';
+function Component({a}) {
   let x = {a};
   let y = {};
   const f0 = function () {
@@ -13,14 +14,22 @@ function component(a) {
   return y;
 }
 
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{a: 2}],
+  sequentialRenders: [{a: 2}, {a: 2}, {a: 3}],
+};
+
 ```
 
 ## Code
 
 ```javascript
 import { c as _c } from "react/compiler-runtime";
-function component(a) {
+import { mutate } from "shared-runtime";
+function Component(t0) {
   const $ = _c(2);
+  const { a } = t0;
   let y;
   if ($[0] !== a) {
     const x = { a };
@@ -39,5 +48,15 @@ function component(a) {
   return y;
 }
 
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{ a: 2 }],
+  sequentialRenders: [{ a: 2 }, { a: 2 }, { a: 3 }],
+};
+
 ```
-      
+      
+### Eval output
+(kind: ok) {"x":{"a":2},"wat0":"joe"}
+{"x":{"a":2},"wat0":"joe"}
+{"x":{"a":3},"wat0":"joe"}
diff --git a/...in-react-compiler/src/__tests__/fixtures/compiler/capturing-func-alias-computed-mutate.js b/...in-react-compiler/src/__tests__/fixtures/compiler/capturing-func-alias-computed-mutate.js
@@ -1,4 +1,5 @@
-function component(a) {
+import {mutate} from 'shared-runtime';
+function Component({a}) {
   let x = {a};
   let y = {};
   const f0 = function () {
@@ -8,3 +9,9 @@ function component(a) {
   mutate(y);
   return y;
 }
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{a: 2}],
+  sequentialRenders: [{a: 2}, {a: 2}, {a: 3}],
+};