[Image] Added onLoadingStart/onLoadingFinish/onLoadingError props #604
Conversation
…age component, which are intended to provide loading states for network image sources. Updated the Image component example in the UIExplorer app to demonstrate how they can be used to fade in a network image (using the Animation API). Fixes facebook#98.
| @@ -88,6 +90,33 @@ var Image = React.createClass({ | |||
| * testing scripts. | |||
| */ | |||
| testID: PropTypes.string, | |||
| /** | |||
| * onLoadingStart - Event callback function to invoke when image load begins. | |||
There was a problem hiding this comment.
nit: can you remove onLoadingStart - from the beginning. We're displaying it twice on the docs and I sent an internal diff to remove the other ones from this file
|
This is awesome! Thanks for doing this! @a2, @nicklockwood can you review? |
|
👍 this would be incredibly useful! |
… the image loading callback functions (instead of merging). Updated the docs to avoid duplicating prop names.
|
👍 That's awesome! |
|
Do we want to stay close to the web here and name them |
| @@ -282,6 +298,9 @@ var styles = StyleSheet.create({ | |||
| width: 38, | |||
| height: 38, | |||
| }, | |||
| hidden: { | |||
| opacity: 0 | |||
There was a problem hiding this comment.
nit: missing a trailing comma
|
Sorry about the review delay, if you rename the event names i'll pull it in :) |
|
This is awesome. One further suggestion, I think it would be better with documentation updated all at once :) |
|
Sure not a problem, I can update docs/Image.md along with the other suggestions. Thanks! |
…TML for load state notifications: onLoadStart, onLoad, onError. Added a section in the Image component docs about the feature including code snippets for a simple image fade-in and using a loading indicator as a placeholder while a large image downloads.
facebook-github-bot
added
the
CLA Signed
…enaming of Animation module to AnimationExperimental.
|
👍👍 i need it |
|
@jordanna maybe you miss |
brentvatne
changed the title
|
This is now implemented. |
Intended to provide loading states for network image sources. Updated the Image component example in the UIExplorer app to demonstrate how they can be used to fade in a network image (using the Animation API). Fixes #98.