fix IOException in BuildCodegenCLITask #48008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
mmm that's suspicious as if that would be the case, the CI would also be right no? How can I reproduce this? #47552 needs more time before we can merge it (cc @huntie) so I'm keen on fixing this issue with this PR if necessary |
|
@vonovak can you share a trace of the failure? |
|
To repro, open https://github.com/facebook/react-native/blob/0.77-stable/build.gradle.kts in android studio. For me it fails doing the gradle sync. When I add
in here I get this trace: Details |
|
LGTM, thanks for opening! @cortinico FYI I put some effort into resurrecting #47552 recently. Closer than ever to landing, but needs a final nontrivial Jest fix in fbsource (sigh). |
|
I didn't get these during any of the release testing (builds triggered from CLI), but I can also repro by just opening the repo root in Android Studio (2024.1.1) 
I don't know in what circumstances the current code would work, as IIUC a In any case the fix LGTM. |
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @vonovak in 9147b07 When will my fix make it into a release? | How to file a pick request? |
robhogan
pushed a commit
that referenced
this pull request
Dec 2, 2024
Summary: building RN tester with 0.77 rc-0 doesn't work now because of `java.io.IOException: No such file or directory` on line 48. `buildDirectory` is a Gradle property representing a file #47552 removes this file altogether so feel free to close if that one is the "right one" ## Changelog: [ANDROID] [FIXED] - fix IOException in `BuildCodegenCLITask` Pull Request resolved: #48008 Test Plan: After this change, building RN tester works. Reviewed By: cortinico Differential Revision: D66650038 Pulled By: robhogan fbshipit-source-id: 11cd83493fa118c6b79d11c9113228dd3971a803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
building RN tester with 0.77 rc-0 doesn't work now because of
java.io.IOException: No such file or directoryon line 48.buildDirectoryis a Gradle property representing a file#47552 removes this file altogether so feel free to close if that one is the "right one"
Changelog:
[ANDROID] [FIXED] - fix IOException in
BuildCodegenCLITaskTest Plan:
After this change, building RN tester works.