Allow fuseboxClientType_ detection from ReactNativeApplication.enable method #47962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66501027 |
3 tasks
huntie
force-pushed
the
export-D66501027
branch
from
dce5859 to
3dce967
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Nov 28, 2024
… method (facebook#47962) Summary: Updates `HostAgent` to respond equivalently if either `FuseboxClient.setClientMetadata` (outgoing) or `ReactNativeApplication.enable` (incoming) are sent by the CDP frontend. This is a partial migration, to be followed by removing the `FuseboxClient.setClientMetadata` method later. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D66501027
|
This pull request was exported from Phabricator. Differential Revision: D66501027 |
… method (facebook#47962) Summary: Updates `HostAgent` to respond equivalently if either `FuseboxClient.setClientMetadata` (outgoing) or `ReactNativeApplication.enable` (incoming) are sent by the CDP frontend. This is a partial migration, to be followed by removing the `FuseboxClient.setClientMetadata` method later. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D66501027
huntie
force-pushed
the
export-D66501027
branch
from
3dce967 to
90e3f8d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66501027 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Nov 28, 2024
… method (facebook#47962) Summary: Updates `HostAgent` to respond equivalently if either `FuseboxClient.setClientMetadata` (outgoing) or `ReactNativeApplication.enable` (incoming) are sent by the CDP frontend. This is a partial migration, to be followed by removing the `FuseboxClient.setClientMetadata` method later. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D66501027
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Nov 28, 2024
Summary: Follows facebook#47962 and depends on facebook/react-native-devtools-frontend#139. Updates the modern debugger server to no longer respond to `FuseboxClient` messages — namely `FuseboxClient.setClientMetadata`. This method was previously used to identify the React Native DevTools frontend, replaced/inferred by `ReactNativeApplication.enable` instead. Changelog: [General][Breaking] - The `FuseboxClient.setClientMetadata` CDP method is removed. Instead, use `ReactNativeApplication.enable`. Differential Revision: D66575324
|
This pull request has been merged in 2fcf7b1. |
|
This pull request was successfully merged by @huntie in 2fcf7b1 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
Summary: Pull Request resolved: #48004 Follows #47962 and depends on facebook/react-native-devtools-frontend#139. Updates the modern debugger server to no longer respond to `FuseboxClient` messages — namely `FuseboxClient.setClientMetadata`. This method is replaced by `ReactNativeApplication.enable` for identifying the React Native DevTools frontend. Changelog: [General][Breaking] - The `FuseboxClient.setClientMetadata` CDP method is removed. Instead, use `ReactNativeApplication.enable`. Reviewed By: rubennorte Differential Revision: D66575324 fbshipit-source-id: f2b4cbacd857931832d89305510f5aaf51df483a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates
HostAgentto respond equivalently if eitherFuseboxClient.setClientMetadata(outgoing) orReactNativeApplication.enable(incoming) are sent by the CDP frontend.This is a partial migration, to be followed by removing the
FuseboxClient.setClientMetadatamethod later.Changelog: [Internal]
Reviewed By: robhogan
Differential Revision: D66501027