Support rn_rootThreshold on IntersectionObserver (viewAreaCoveragePercentThreshold)
#47908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66031119 |
…ercentThreshold)
Summary:
Changelog: [General][Added] - Add support for `rn_rootThreshold` in Intersection Observer
`rn_rootThreshold` is a custom IntersectionObserver option and not part of the IntersectionObserver spec. We are adding it because it covers a specific use-case for measuring viewability that is robust for `target`s that are larger than the viewport or specified `root`.
The threshold ratio is of the intersection area (of `root` and `target`) to the total area of the `root`.
{F1960832959}
Source - EX314979
`rn_rootThreshold` is an optional threshold and can be combined with the `thresholds` option. An intersection will fire if any specified thresholds is met.
Note: If you use specify a `rn_rootThreshold`, the default `threshold` is no longer applied
The main use case of `rn_rootThreshold` is being able to specify a level of viewability independent of `target` size. For example, a `target` that is larger than the `root` (commonly the viewport) will not trigger the IntersectionObserver for a `threshold` of `1`. Setting `rn_rootThreshold` of `1`, will trigger once the item takes full size of the `root`.';
Reviewed By: yungsters
Differential Revision: D66031119
lunaleaps
force-pushed
the
export-D66031119
branch
from
02fac84 to
fb22d3a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66031119 |
|
This pull request has been merged in a77d8d9. |
|
This pull request was successfully merged by @lunaleaps in a77d8d9 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add support for
rn_rootThreshold.rn_rootThresholdis a custom IntersectionObserver option and not part of the IntersectionObserver spec. We are adding it because it covers a specific use-case for measuring viewability that is robust fortargets that are larger than the viewport or specifiedroot.The threshold ratio is of the intersection area (of
rootandtarget) to the total area of theroot.{F1960832959}
Source - EX314979
rn_rootThresholdis an optional threshold and can be combined with thethresholdsoption. An intersection will fire if any specified thresholds is met.Note: If you use specify a
rn_rootThreshold, the defaultthresholdis no longer appliedThe main use case of
rn_rootThresholdis being able to specify a level of viewability independent oftargetsize. For example, atargetthat is larger than theroot(commonly the viewport) will not trigger the IntersectionObserver for athresholdof1. Settingrn_rootThresholdof1, will trigger once the item takes full size of theroot.';Reviewed By: yungsters
Differential Revision: D66031119