Remove experimental_ prefix from filter
#46406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62401985 |
Differential Revision: D62400814
|
This pull request was exported from Phabricator. Differential Revision: D62401985 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Sep 11, 2024
Summary: Pull Request resolved: facebook#46406 As title Second attempt at landing the new name. There were 2 issues previously which led us to revert. 1. **Error on workrooms tests.** This ended up not being caused by us but rather by D61896776. After renaming the error changed which might've caused the renaming to be blamed for the issue. It has since been resolved 2. **FB crash** FB was crashing when using drop-shadow after renaming. For some reason after renaming `filter` an invalid stylex property was making FB crash. We don't know why renaming uncovered the issue but the the code was using unsupported features on RN (`calc` & `stylex`) which then led to passing a raw unsupported value for `filter` and crashing on the `processFilter` function. FB was fixed here D62407454 to prevent crashing after landing this diff Changelog: [General] [Changed] - Add official `filter` CSSProperty. Differential Revision: D62401985
jorge-cab
force-pushed
the
export-D62401985
branch
from
639ad53 to
3f71f66
Compare
Summary: Pull Request resolved: facebook#46406 As title Second attempt at landing the new name. There were 2 issues previously which led us to revert. 1. **Error on workrooms tests.** This ended up not being caused by us but rather by D61896776. After renaming the error changed which might've caused the renaming to be blamed for the issue. It has since been resolved 2. **FB crash** FB was crashing when using drop-shadow after renaming. For some reason after renaming `filter` an invalid stylex property was making FB crash. We don't know why renaming uncovered the issue but the the code was using unsupported features on RN (`calc` & `stylex`) which then led to passing a raw unsupported value for `filter` and crashing on the `processFilter` function. FB was fixed here D62407454 to prevent crashing after landing this diff Changelog: [General] [Changed] - Add official `filter` CSSProperty. Differential Revision: D62401985
|
This pull request was exported from Phabricator. Differential Revision: D62401985 |
jorge-cab
force-pushed
the
export-D62401985
branch
from
3f71f66 to
08cbd8e
Compare
|
This pull request has been merged in 6b369a4. |
|
This pull request was successfully merged by @jorge-cab in 6b369a4 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Sep 16, 2024
Summary: Pull Request resolved: #46406 As title Second attempt at landing the new name. There were 2 issues previously which led us to revert. 1. **Error on workrooms tests.** This ended up not being caused by us but rather by D61896776. After renaming the error changed which might've caused the renaming to be blamed for the issue. It has since been resolved 2. **FB crash** FB was crashing when using drop-shadow after renaming. For some reason after renaming `filter` an invalid stylex property was making FB crash. We don't know why renaming uncovered the issue but the the code was using unsupported features on RN (`calc` & `stylex`) which then led to passing a raw unsupported value for `filter` and crashing on the `processFilter` function. FB was fixed here D62407454 to prevent crashing after landing this diff Changelog: [General] [Changed] - Add official `filter` CSSProperty. Reviewed By: NickGerleman Differential Revision: D62401985 fbshipit-source-id: 14422603c40b7ddf8300029165a85655354075c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title
Changelog: [General] [Changed] - Add official
filterCSSProperty.Differential Revision: D62401985