Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle textAlignment: start #45076

Closed
wants to merge 1 commit into from
Closed

Conversation

javache
Copy link
Member

@javache javache commented Jun 19, 2024

Summary:

start: The same as left if direction is left-to-right and right if direction is right-to-left.

This is equivalent to auto, which is not actually a valid CSS value.

Changelog: [General][Added] Add support for texAlignment: 'start'

Differential Revision: D58791937

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 19, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58791937

@analysis-bot
Copy link

analysis-bot commented Jun 19, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,478,737 +9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,676,536 +20
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 2a6a895
Branch: main

Summary:
Pull Request resolved: facebook#45076

> **start**: The same as left if direction is left-to-right and right if direction is right-to-left.

This is equivalent to `auto`, which is not actually a valid CSS value.

Changelog: [General][Added] Add support for `texAlignment: 'start'`

Differential Revision: D58791937
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58791937

@javache javache force-pushed the export-D58791937 branch from 04760b3 to 4ccc694 Compare June 20, 2024 09:26
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a2cb343.

Copy link

This pull request was successfully merged by @javache in a2cb343.

When will my fix make it into a release? | How to file a pick request?

@javache javache deleted the export-D58791937 branch June 24, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants