Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the template from react-native package #45008

Closed
wants to merge 2 commits into from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Jun 17, 2024

Summary:
As part of RFC0759, we are moving the template into it's own repository.

Useful Links:

Changelog: [General][Breaking] removed the template from react-native into react-native-community/template

Reviewed By: cortinico

Differential Revision: D58184276

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58184276

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58184276

@blakef blakef force-pushed the export-D58184276 branch from c11a07d to 2615e5a Compare June 17, 2024 15:07
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58184276

@blakef blakef force-pushed the export-D58184276 branch from 2615e5a to e6ee22d Compare June 17, 2024 15:14
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58184276

@blakef blakef force-pushed the export-D58184276 branch from e6ee22d to c884bfe Compare June 17, 2024 15:30
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58184276

@blakef blakef force-pushed the export-D58184276 branch from c884bfe to 6874277 Compare June 17, 2024 15:47
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58184276

@blakef blakef force-pushed the export-D58184276 branch from 6874277 to 53ac8f2 Compare June 17, 2024 16:19
@analysis-bot
Copy link

analysis-bot commented Jun 17, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,443,789 -3
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,642,468 -1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4792671
Branch: main

blakef added 2 commits June 17, 2024 11:30
…mplate is removed (#44908)

Summary:
Pull Request resolved: #44908

Changelog: [General] [Changed] - CircleCI test to Helloworld, but disabled for now until we remove the template

Differential Revision: D58469912

Reviewed By: cipolleschi
Summary:
Pull Request resolved: #45008

As part of RFC0759, we are moving the template into it's own repository.

## Useful Links:
- [Section in RFC0759](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0759-react-native-frameworks.md#evolving-the-react-native-community-template--cli)
- [Template's new home](https://github.com/react-native-community/template)
- [Versioning discussion](react-native-community/cli#2345)

Changelog: [General][Breaking] removed the template from react-native into react-native-community/template

Reviewed By: cortinico

Differential Revision: D58184276
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58184276

@blakef blakef force-pushed the export-D58184276 branch from 53ac8f2 to c931353 Compare June 17, 2024 18:40
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 17, 2024
Copy link

This pull request was successfully merged by @blakef in 07abfce.

When will my fix make it into a release? | How to file a pick request?

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 07abfce.

cipolleschi pushed a commit that referenced this pull request Jun 18, 2024
Summary:
Pull Request resolved: #45008

As part of RFC0759, we are moving the template into it's own repository.

- [Section in RFC0759](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0759-react-native-frameworks.md#evolving-the-react-native-community-template--cli)
- [Template's new home](https://github.com/react-native-community/template)
- [Versioning discussion](react-native-community/cli#2345)

Changelog: [General][Breaking] removed the template from react-native into react-native-community/template

Reviewed By: cortinico

Differential Revision: D58184276

fbshipit-source-id: 5e52320af55495488587accbe144d11164cea4fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants