Fix bridge mode by constructing ReactDelegate correctly. #43999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
Currently NewArch-BridgeMode is partially broken when creating views via `ReactDelegate`.
That's because we're using the ctor that doesn't account for `Boolean: fabricEnabled`.
That means that the `RootView` that it will be created are all having setIsFabric(FALSE).
This is causing problems like whitescreens on several reload + multiple warnings such as:
```
E com.facebook.react.bridge.ReactNoCrashSoftException: Cannot get UIManager because the context doesn't contain an active CatalystInstance.
```
Fixes facebook#43692
See for more context on this issues: facebook#43692
Changelog:
[Android] [Fixed] - Fix bridge mode by constructing ReactDelegate correctly
Reviewed By: cipolleschi
Differential Revision: D55921078
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55921078 |
Base commit: b23960a |
|
This pull request has been merged in a25004c. |
|
This pull request was successfully merged by @cortinico in a25004c. When will my fix make it into a release? | How to file a pick request? |
cortinico
added a commit
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: #43999 Currently NewArch-BridgeMode is partially broken when creating views via `ReactDelegate`. That's because we're using the ctor that doesn't account for `Boolean: fabricEnabled`. That means that the `RootView` that it will be created are all having setIsFabric(FALSE). This is causing problems like whitescreens on several reload + multiple warnings such as: ``` E com.facebook.react.bridge.ReactNoCrashSoftException: Cannot get UIManager because the context doesn't contain an active CatalystInstance. ``` Fixes #43692 See for more context on this issues: #43692 Changelog: [Android] [Fixed] - Fix bridge mode by constructing ReactDelegate correctly Reviewed By: cipolleschi Differential Revision: D55921078 fbshipit-source-id: 2c21d089a49538402d546177bcdb26c8d7d5fbc1
This was referenced Apr 9, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently NewArch-BridgeMode is partially broken when creating views via
ReactDelegate.That's because we're using the ctor that doesn't account for
Boolean: fabricEnabled.That means that the
RootViewthat it will be created are all having setIsFabric(FALSE).This is causing problems like whitescreens on several reload + multiple warnings such as:
Fixes #43692
See for more context on this issues: #43692
Changelog:
[Android] [Fixed] - Fix bridge mode by constructing ReactDelegate correctly
Reviewed By: cipolleschi
Differential Revision: D55921078