Make codegenNativeComponent show warning and not error #43070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53761805 |
dmytrorykun
force-pushed
the
export-D53761805
branch
from
d7db18b to
8301bf9
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 19, 2024
Summary: **Context** The `codegenNativeComponent` function is a hint for the codegen that the file that contains it is a Native Component spec. Static ViewConfig codegen overwrites this function call by the generated ViewConfig. If this function is not overwritten by the codegen, it has runtime behaviour that falls back to `requireNativeComponent`. At the time when this system was built `requireNativeComponent` was not supported in Bridgeless mode because it is relied on some Bridge-only functionality. That's why it outputs error in Bridgeless mode. --- This is not the case any more, we now have interop layers which provide the functionality needed by `requireNativeComponent`. The SVC codegen is implemented as [Babel plugin](https://github.com/facebook/react-native/tree/main/packages/babel-plugin-codegen). The are scenarios when it is not run for the native component specs: - If the plugin is not used for whatever reason. - If Babel is not used for whatever reason. In order to not to regress the DevX for such cases, we've turned the error into the warning. **Note:** we use `console.info('⚠️ ...` instead of `console.warn('...`. That's because `console.warn` also prints a stack trace in the console, and we didn't want to create too much noise. Changelog: [General][Changed] - codegenNativeComponent show warning and not error if not code generated at build time. Reviewed By: fkgozali Differential Revision: D53761805
|
This pull request was exported from Phabricator. Differential Revision: D53761805 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 19, 2024
Summary: **Context** The `codegenNativeComponent` function is a hint for the codegen that the file that contains it is a Native Component spec. Static ViewConfig codegen overwrites this function call by the generated ViewConfig. If this function is not overwritten by the codegen, it has runtime behaviour that falls back to `requireNativeComponent`. At the time when this system was built `requireNativeComponent` was not supported in Bridgeless mode because it is relied on some Bridge-only functionality. That's why it outputs error in Bridgeless mode. --- This is not the case any more, we now have interop layers which provide the functionality needed by `requireNativeComponent`. The SVC codegen is implemented as [Babel plugin](https://github.com/facebook/react-native/tree/main/packages/babel-plugin-codegen). The are scenarios when it is not run for the native component specs: - If the plugin is not used for whatever reason. - If Babel is not used for whatever reason. In order to not to regress the DevX for such cases, we've turned the error into the warning. **Note:** we use `console.info('⚠️ ...` instead of `console.warn('...`. That's because `console.warn` also prints a stack trace in the console, and we didn't want to create too much noise. Changelog: [General][Changed] - codegenNativeComponent show warning and not error if not code generated at build time. Reviewed By: fkgozali Differential Revision: D53761805
dmytrorykun
force-pushed
the
export-D53761805
branch
from
8301bf9 to
1b7786e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53761805 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53761805 |
dmytrorykun
force-pushed
the
export-D53761805
branch
from
1b7786e to
840a238
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 20, 2024
Summary: **Context** The `codegenNativeComponent` function is a hint for the codegen that the file that contains it is a Native Component spec. Static ViewConfig codegen overwrites this function call by the generated ViewConfig. If this function is not overwritten by the codegen, it has runtime behaviour that falls back to `requireNativeComponent`. At the time when this system was built `requireNativeComponent` was not supported in Bridgeless mode because it is relied on some Bridge-only functionality. That's why it outputs error in Bridgeless mode. --- This is not the case any more, we now have interop layers which provide the functionality needed by `requireNativeComponent`. The SVC codegen is implemented as [Babel plugin](https://github.com/facebook/react-native/tree/main/packages/babel-plugin-codegen). The are scenarios when it is not run for the native component specs: - If the plugin is not used for whatever reason. - If Babel is not used for whatever reason. In order to not to regress the DevX for such cases, we've turned the error into the warning. **Note:** we use `console.info('⚠️ ...` instead of `console.warn('...`. That's because `console.warn` also prints a stack trace in the console, and we didn't want to create too much noise. Changelog: [General][Changed] - codegenNativeComponent show warning and not error if not code generated at build time. Reviewed By: rshest Differential Revision: D53761805
|
This pull request was exported from Phabricator. Differential Revision: D53761805 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 20, 2024
Summary: **Context** The `codegenNativeComponent` function is a hint for the codegen that the file that contains it is a Native Component spec. Static ViewConfig codegen overwrites this function call by the generated ViewConfig. If this function is not overwritten by the codegen, it has runtime behaviour that falls back to `requireNativeComponent`. At the time when this system was built `requireNativeComponent` was not supported in Bridgeless mode because it is relied on some Bridge-only functionality. That's why it outputs error in Bridgeless mode. --- This is not the case any more, we now have interop layers which provide the functionality needed by `requireNativeComponent`. The SVC codegen is implemented as [Babel plugin](https://github.com/facebook/react-native/tree/main/packages/babel-plugin-codegen). The are scenarios when it is not run for the native component specs: - If the plugin is not used for whatever reason. - If Babel is not used for whatever reason. In order to not to regress the DevX for such cases, we've turned the error into the warning. **Note:** we use `console.info('⚠️ ...` instead of `console.warn('...`. That's because `console.warn` also prints a stack trace in the console, and we didn't want to create too much noise. Changelog: [General][Changed] - codegenNativeComponent show warning and not error if not code generated at build time. Reviewed By: huntie, rshest Differential Revision: D53761805
dmytrorykun
force-pushed
the
export-D53761805
branch
from
840a238 to
6f4f290
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53761805 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 20, 2024
Summary: **Context** The `codegenNativeComponent` function is a hint for the codegen that the file that contains it is a Native Component spec. Static ViewConfig codegen overwrites this function call by the generated ViewConfig. If this function is not overwritten by the codegen, it has runtime behaviour that falls back to `requireNativeComponent`. At the time when this system was built `requireNativeComponent` was not supported in Bridgeless mode because it is relied on some Bridge-only functionality. That's why it outputs error in Bridgeless mode. --- This is not the case any more, we now have interop layers which provide the functionality needed by `requireNativeComponent`. The SVC codegen is implemented as [Babel plugin](https://github.com/facebook/react-native/tree/main/packages/babel-plugin-codegen). The are scenarios when it is not run for the native component specs: - If the plugin is not used for whatever reason. - If Babel is not used for whatever reason. In order to not to regress the DevX for such cases, we've turned the error into the warning. **Note:** we use `console.info('⚠️ ...` instead of `console.warn('...`. That's because `console.warn` also prints a stack trace in the console, and we didn't want to create too much noise. Changelog: [General][Changed] - codegenNativeComponent show warning and not error if not code generated at build time. Reviewed By: huntie, rshest Differential Revision: D53761805
dmytrorykun
force-pushed
the
export-D53761805
branch
from
6f4f290 to
35e9439
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53761805 |
Summary: **Context** The `codegenNativeComponent` function is a hint for the codegen that the file that contains it is a Native Component spec. Static ViewConfig codegen overwrites this function call by the generated ViewConfig. If this function is not overwritten by the codegen, it has runtime behaviour that falls back to `requireNativeComponent`. At the time when this system was built `requireNativeComponent` was not supported in Bridgeless mode because it is relied on some Bridge-only functionality. That's why it outputs error in Bridgeless mode. --- This is not the case any more, we now have interop layers which provide the functionality needed by `requireNativeComponent`. The SVC codegen is implemented as [Babel plugin](https://github.com/facebook/react-native/tree/main/packages/babel-plugin-codegen). The are scenarios when it is not run for the native component specs: - If the plugin is not used for whatever reason. - If Babel is not used for whatever reason. In order to not to regress the DevX for such cases, we've turned the error into the warning. **Note:** we use `console.info('⚠️ ...` instead of `console.warn('...`. That's because `console.warn` also prints a stack trace in the console, and we didn't want to create too much noise. Changelog: [General][Changed] - codegenNativeComponent show warning and not error if not code generated at build time. Reviewed By: huntie, rshest Differential Revision: D53761805
dmytrorykun
force-pushed
the
export-D53761805
branch
from
35e9439 to
81bbc6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53761805 |
|
This pull request was successfully merged by @dmytrorykun in de5619e. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in de5619e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
The
codegenNativeComponentfunction is a hint for the codegen that the file that contains it is a Native Component spec. Static ViewConfig codegen overwrites this function call by the generated ViewConfig.If this function is not overwritten by the codegen, it has runtime behaviour that falls back to
requireNativeComponent. At the time when this system was builtrequireNativeComponentwas not supported in Bridgeless mode because it is relied on some Bridge-only functionality. That's why it outputs error in Bridgeless mode.This is not the case any more, we now have interop layers which provide the functionality needed by
requireNativeComponent.The SVC codegen is implemented as Babel plugin. The are scenarios when it is not run for the native component specs:
In order to not to regress the DevX for such cases, we've turned the error into the warning.
Note: we use
console.info('⚠️...instead ofconsole.warn('.... That's becauseconsole.warnalso prints a stack trace in the console, and we didn't want to create too much noise.Changelog: [General][Changed] - codegenNativeComponent show warning and not error if not code generated at build time.
Differential Revision: D53761805