Delete traitCast and identifier traits #42748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53215009 |
Summary: If left and right are swapped, this code assumes every yoga layoutable shadownode is a view, and mutates its props as if they were ViewProps. This is not safe, and could lead to memory corruption. Changelog: [Internal] Differential Revision: D53213652
Summary:
React Native has globally enabled RTTI within `rn_xplat_cxx_library`, ahead of RTTI being forced on (regardless of flag) in Android apps.
This diff:
1. Mechanically replaces usages of `traitCast` with equivalent calls to `dynamic_cast` or `dynamic_pointer_cast`
1. These have similar semantics as current iteration of `traitCast`, where we return `nullptr` for pointer form, or throw on invalid cast for reference form.
2. Removes `IdentifierTrait` as a requirement to cast to a ShadowNode
3. Removes the ShadowNode traits used solely as cast identities
The OSS builds should already have RTTI on, and will be able to use `dynamic_cast` on RN provided types (`traitCast` is not extendable).
Changelog:
[General][Breaking] - Delete traitCast and identifier traits
Differential Revision: D53215009
NickGerleman
force-pushed
the
export-D53215009
branch
from
abacfad to
6e717c3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53215009 |
Base commit: c7479b0 |
|
This pull request has been merged in 1170a68. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
React Native has globally enabled RTTI within
rn_xplat_cxx_library, ahead of RTTI being forced on (regardless of flag) in Android apps.This diff:
traitCastwith equivalent calls todynamic_castordynamic_pointer_casttraitCast, where we returnnullptrfor pointer form, or throw on invalid cast for reference form.IdentifierTraitas a requirement to cast to a ShadowNodeThe OSS builds should already have RTTI on, and will be able to use
dynamic_caston RN provided types (traitCastis not extendable).Changelog:
[General][Breaking] - Delete traitCast and identifier traits
Differential Revision: D53215009