Set navigator.product to ReactNative #4083
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
| @@ -154,6 +154,14 @@ function setUpGeolocation() { | |||
| polyfillGlobal('geolocation', require('Geolocation'), GLOBAL.navigator); | |||
| } | |||
|
|
|||
| function setUpProduct() { | |||
| let rn_version = require('../../../package.json').version; | |||
There was a problem hiding this comment.
nit: camel case rnVersion.
cc @vjeux will this package.json require work for facebook?
|
@chetstone updated the pull request. |
|
@vjeux Out of curiosity, is this likely to land soon? We could make use of it in the Firebase client to make it work better on React Native. |
| @@ -154,6 +154,14 @@ function setUpGeolocation() { | |||
| polyfillGlobal('geolocation', require('Geolocation'), GLOBAL.navigator); | |||
| } | |||
|
|
|||
| function setUpProduct() { | |||
| let rnVersion = require('../../../package.json').version; | |||
There was a problem hiding this comment.
I'm sorry but this won't work. We're trying very hard to make the size of the js file we load smaller as it has a direct impact on the time it takes to start up. Loading the entire package.json in memory just to get the version number is really bad :(
Could we punt on the version number for now and just get product there for now.
I also think that using the react-native field of package.json is going to be a more robust way to deal with detection rather than reading this global variable.
There was a problem hiding this comment.
@vjeux good points. I also think it's going to be a mess for the next while if libraries are trying to target specific RN versions until we hit 1.0 in 2017 or 2018 (maybe 2016, surprise me!)
|
Thanks for the pull request and sorry for the delay. Can you remove the version number for now and i'll pull it in? Thanks! |
|
@mikelehen This pull request that was merged today is going to be the way we recommend third party to do feature detection on react-native node modules: #2208 |
chetstone
force-pushed
the
issue-1331
branch
from
755c544 to
3c65e62
Compare
|
@chetstone updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1732367296995240/int_phab to review. |
ghost
closed this
in
Summary: Fix for [Issue 1331](facebook#1331). Sets navigator.product to ReactNative and navigator.productSub to the version string in package.json. Note that the code requires package.json, which works fine in the RN packager, but webpack users will probably a need to configure a json loader in their config file. Tested using UIExplorer and console.log printout of the product variables in xcode and Chrome debugger. Closes facebook#4083 Reviewed By: svcscm Differential Revision: D2696881 Pulled By: vjeux fb-gh-sync-id: 511446432dcd0ec658100715129c77153e743423
Summary: Fix for [Issue 1331](facebook#1331). Sets navigator.product to ReactNative and navigator.productSub to the version string in package.json. Note that the code requires package.json, which works fine in the RN packager, but webpack users will probably a need to configure a json loader in their config file. Tested using UIExplorer and console.log printout of the product variables in xcode and Chrome debugger. Closes facebook#4083 Reviewed By: svcscm Differential Revision: D2696881 Pulled By: vjeux fb-gh-sync-id: 511446432dcd0ec658100715129c77153e743423
Fix for Issue 1331. Sets navigator.product to ReactNative and navigator.productSub to the version string in package.json.
Note that the code requires package.json, which works fine in the RN packager, but webpack users will probably a need to configure a json loader in their config file.
Tested using UIExplorer and console.log printout of the product variables in xcode and Chrome debugger.