Do not attempt to comment on PRs when on forks #36316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico can you also add this conditional to the rest of the GitHub workflows? Provided @SlyCaptainFlint also agrees. |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 14ab76a |
|
@cortinico merged this pull request in d56bd11. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: I'm gating this workflow to run only upstream as I'm receiving notifications that it fails on my fork. We don't want to run this workflow on forks at all hence we can add a `if:` there. ## Changelog [INTERNAL] - Do not attempt to comment on PRs when on forks Pull Request resolved: facebook#36316 Test Plan: If Github Actions UI is green, we're good to go Reviewed By: cipolleschi Differential Revision: D43657315 Pulled By: cortinico fbshipit-source-id: 8fb260d142a43375bd9a3b10eac235550a6aecb0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm gating this workflow to run only upstream as I'm receiving notifications that it fails on my fork. We don't want to run this workflow on forks at all hence we can add a
if:there.Changelog
[INTERNAL] - Do not attempt to comment on PRs when on forks
Test Plan
If Github Actions UI is green, we're good to go