-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: RCTConvert - allocate array with capacity #35490
Conversation
Base commit: ca1ae5c |
PR build artifact for e91fe36 is ready. |
Doesn't look like its building :) - double check your syntax. I believe you have an extra |
lol, since it was just a one-liner I didn't bother to create a branch and push from it locally, and just copy-pasted in the GH ui... well, now it's fixed. Thanks 👍 |
Base commit: ca1ae5c |
PR build artifact for 5ff140a is ready. |
@GijsWeterings has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @vonovak in e325c95. When will my fix make it into a release? | Upcoming Releases |
Summary: this is a trivial change that allocates the NSMutableArray with the correct capacity before it is filled ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - RCTConvertVecToArray - allocate array with capacity Pull Request resolved: facebook#35490 Test Plan: tested locally: the code builds and runs as expected Reviewed By: cipolleschi Differential Revision: D41548050 Pulled By: GijsWeterings fbshipit-source-id: a5b947331d6c5fffcfecc7c20c827f42442b1ab8
Summary
this is a trivial change that allocates the NSMutableArray with the correct capacity before it is filled
Changelog
[Internal] [Changed] - RCTConvertVecToArray - allocate array with capacity
Test Plan
tested locally: the code builds and runs as expected