Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the tail-spacer gets negative values in VirtualizedList on scrolling toward new items with dynamic height. #35413

Closed
wants to merge 1 commit into from
Closed

Prevent the tail-spacer gets negative values in VirtualizedList on scrolling toward new items with dynamic height. #35413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Libraries/Lists/VirtualizedList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,8 +907,10 @@ export default class VirtualizedList extends StateSafePureComponent<
this.props,
);
const lastMetrics = this.__getFrameMetricsApprox(last, this.props);
const spacerSize =
lastMetrics.offset + lastMetrics.length - firstMetrics.offset;
const spacerSize = Math.max(
lastMetrics.offset + lastMetrics.length - firstMetrics.offset,
0,
);
cells.push(
<View
key={`$spacer-${section.first}`}
Expand Down