-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VirtualizedList onViewableItemsChanged won't trigger if first item in data evaluate to false #35280 #35282
Conversation
f79aade
to
bc2dbbb
Compare
Hi @samchan0221! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
…m in data evaluate to false facebook#35280
bc2dbbb
to
bb88eae
Compare
Base commit: 5744b21 |
Base commit: 5744b21 |
PR build artifact for bb88eae is ready. |
PR build artifact for bb88eae is ready. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
… data evaluate to false facebook#35280 (facebook#35282) Summary: VirtualizedList onViewableItemsChanged won't trigger if first item in data evaluate to false facebook#35280 Described in facebook#35280 ## Changelog - [General] [Fixed] Fix VirtualizedList onViewableItemsChanged won't trigger if first item in data evaluate to false Pull Request resolved: facebook#35282 Test Plan: this snack will be able to log `onViewableItemsChanged triggered` after the fix: https://snack.expo.dev/tmQo_R_3Y Reviewed By: jacdebug Differential Revision: D41158485 Pulled By: NickGerleman fbshipit-source-id: 47434890155abe009c2560b658adc4e067c31027
VirtualizedList onViewableItemsChanged won't trigger if first item in data evaluate to false #35280
Summary
Described in #35280
Changelog
Test Plan
this snack will be able to log
onViewableItemsChanged triggered
after the fix:https://snack.expo.dev/tmQo_R_3Y