Extracted IncorrectModuleRegistryCallTypeParameterParserError to throwIfIncorrectModuleRegistryCallTypeParameterParserError #34941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wIfIncorrectModuleRegistryCallTypeParameterParserError
Base commit: a885b1f |
Base commit: a885b1f |
cipolleschi
requested changes
Oct 11, 2022
packages/react-native-codegen/src/parsers/__tests__/error-utils-test.js
Outdated
Show resolved
Hide resolved
packages/react-native-codegen/src/parsers/__tests__/error-utils-test.js
Outdated
Show resolved
Hide resolved
packages/react-native-codegen/src/parsers/__tests__/error-utils-test.js
Outdated
Show resolved
Hide resolved
packages/react-native-codegen/src/parsers/__tests__/error-utils-test.js
Outdated
Show resolved
Hide resolved
|
Could you also rebase on |
facebook-github-bot
added
the
CLA Signed
cipolleschi
approved these changes
Oct 12, 2022
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @harshsiri110 in bb519ec. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
…wIfIncorrectModuleRegistryCallTypeParameterParserError (facebook#34941) Summary: This PR is part of facebook#34872. This PR extracts `IncorrectModuleRegistryCallTypeParameterParserError` exception to a separate function inside an `error-utils.js` file ## Changelog [Internal] [Changed] - Extract `IncorrectModuleRegistryCallTypeParameterParserError` to a seperate function inside `error-utils.js` Pull Request resolved: facebook#34941 Test Plan: ```sh yarn jest react-native-codegen ``` Added unit case in `error-utils-test.js` file <img width="940" alt="Screenshot 2022-10-11 at 4 42 03 PM" src="https://user-images.githubusercontent.com/86605635/195076564-3b023c17-661c-4330-805c-0216c4391d59.png"> Reviewed By: dmytrorykun Differential Revision: D40296642 Pulled By: cipolleschi fbshipit-source-id: 7c7bba6a4f68e9b8fa4729a7651f22cce6d7ca6e
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…wIfIncorrectModuleRegistryCallTypeParameterParserError (facebook#34941) Summary: This PR is part of facebook#34872. This PR extracts `IncorrectModuleRegistryCallTypeParameterParserError` exception to a separate function inside an `error-utils.js` file ## Changelog [Internal] [Changed] - Extract `IncorrectModuleRegistryCallTypeParameterParserError` to a seperate function inside `error-utils.js` Pull Request resolved: facebook#34941 Test Plan: ```sh yarn jest react-native-codegen ``` Added unit case in `error-utils-test.js` file <img width="940" alt="Screenshot 2022-10-11 at 4 42 03 PM" src="https://user-images.githubusercontent.com/86605635/195076564-3b023c17-661c-4330-805c-0216c4391d59.png"> Reviewed By: dmytrorykun Differential Revision: D40296642 Pulled By: cipolleschi fbshipit-source-id: 7c7bba6a4f68e9b8fa4729a7651f22cce6d7ca6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of #34872.
This PR extracts
IncorrectModuleRegistryCallTypeParameterParserErrorexception to a separate function inside anerror-utils.jsfileChangelog
[Internal] [Changed] - Extract
IncorrectModuleRegistryCallTypeParameterParserErrorto a seperate function insideerror-utils.jsTest Plan
Added unit case in
error-utils-test.jsfile