Re-implement accessibilityHint on Android to use AccessibililltyNodeInfo#setToolTipText instead of contentDescription #34427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook#31056 (comment) >Re-implement accessibilityHint on Android so that rather that concatenate into the contentDescription, it sets the toolTipText property on the AccessibilityNodeInfo (not on the view). This is the closest analog to iOS's hint that Android has, as the text is announced after the contentDescription rather than part of it. It will will not adhere to users preferences on whether they want hints disabled or not, and still has no pause before it like real hints have, but it's far closer than using the contentDescription directly.
…sibilityHint. Tasks: - Review the DRAFT implementation in the commit - Plan tasks to implement the final solution - Retrieve the accessibilityHint from the ReactAccessibilityDelegate using getTag(accessibility_hint) - Add setTooltipText onInitializeAccessibilityNodeInfo to set the accessibilityHint. - Verify that the tooltip is announced with TalkBack. - Read conversation in facebook#31056 - Record video of test case after fixing issue facebook#31056 https://user-images.githubusercontent.com/24992535/184837154-5c65dbf1-1031-4d56-ac1e-066af7e08edc.mp4
facebook-github-bot
added
the
CLA Signed
Base commit: 163171c |
Base commit: 163171c |
facebook-github-bot
added
the
Shared with Meta
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @fabriziobertoglio1987, thanks for the PR. Could you try to rebase it onto |
|
Thanks @cipolleschi, I rebased and the CI is green. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @fabriziobertoglio1987 in 0b70b38. When will my fix make it into a release? | Upcoming Releases |
raykle
pushed a commit
to raykle/react-native
that referenced
this pull request
Aug 27, 2022
…nfo#setToolTipText instead of contentDescription (facebook#34427) Summary: facebook#31056 (comment) >Re-implement accessibilityHint on Android so that rather that concatenate into the contentDescription, it sets the toolTipText property on the AccessibilityNodeInfo (not on the view). This is the closest analog to iOS's hint that Android has, as the text is announced after the contentDescription rather than part of it. It will will not adhere to users preferences on whether they want hints disabled or not, and still has no pause before it like real hints have, but it's far closer than using the contentDescription directly. fixes facebook#31056 ## Changelog [Android] [Fixed] - Re-implement accessibilityHint on Android to use AccessibililltyNodeInfo#setToolTipText instead of contentDescription Pull Request resolved: facebook#34427 Test Plan: https://user-images.githubusercontent.com/24992535/184837154-5c65dbf1-1031-4d56-ac1e-066af7e08edc.mp4 Reviewed By: christophpurrer Differential Revision: D38982158 Pulled By: cipolleschi fbshipit-source-id: 7a616e6df9f83bd21ca02cc26b5918986a1d64f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#31056 (comment)
fixes #31056
Changelog
[Android] [Fixed] - Re-implement accessibilityHint on Android to use AccessibililltyNodeInfo#setToolTipText instead of contentDescription
Test Plan
2022-08-16.16-38-12.mp4