Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue for android 16 device.Fixes #22294 #22295

Closed
wants to merge 1 commit into from
Closed

Fix compatibility issue for android 16 device.Fixes #22294 #22295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/AndroidInfoHelpers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
Copy link

@hey99xx hey99xx Nov 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not deleting this line ( import java.nio.charset.StandardCharsets )? it won't crash but still incorrect to import it, may be accidentaly used again in the future

import java.util.Locale;

Expand Down Expand Up @@ -84,7 +85,7 @@ private static synchronized String getMetroHostPropValue() {
Runtime.getRuntime().exec(new String[] {"/system/bin/getprop", METRO_HOST_PROP_NAME});
reader =
new BufferedReader(
new InputStreamReader(process.getInputStream(), StandardCharsets.UTF_8));
new InputStreamReader(process.getInputStream(), Charset.forName("UTF-8")));

String lastLine = "";
String line;
Expand Down