-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove height styling when keyboard closed #16965
Conversation
@shauns I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
Hey @shauns, happy new year! I ran across this issue today, do you have time to take another look at this PR? |
I think this needs to be merged as soon as possible, it's a very simple fix which solves a very annoying issue for a lot of users. What can we do to have this move forward? @hramos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test plan and the explanation. The code comment also explains that this code should only be used when this.state.bottom > 0
but it isn't validated anywhere. I'll land this.
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Closes facebook#13754 Fixing previously reported bug facebook#13754 Video here https://imgur.com/a/3IgqP [GENERAL] [BUGFIX] [KeyboardAvoidingView] - Correct height behaviour when keyboard closed Pull Request resolved: facebook#16965 Differential Revision: D13860208 Pulled By: cpojer fbshipit-source-id: 9ae7f81fd24999518a6ae85016d4f75dac3c4274
Closes #13754
Motivation
Fixing previously reported bug #13754
Test Plan
Video here https://imgur.com/a/3IgqP
Release Notes
[GENERAL] [BUGFIX] [KeyboardAvoidingView] - Correct height behaviour when keyboard closed