Fix markdown in requiresMainQueueSetup warning #16916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
@facebook-github-bot label Needs more information @facebook-github-bot label Core Team Attention: @shergin Generated by 🚫 dangerJS |
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 22, 2017
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Can anyone explain when we should set |
ide
pushed a commit
that referenced
this pull request
Nov 28, 2017
Summary: nit-picking [IOS] [MINOR] [React/Base/RCTModuleData.mm] - Fix markdown in `requiresMainQueueSetup` warning Closes #16916 Differential Revision: D6394725 Pulled By: shergin fbshipit-source-id: 272c5a6ee529af0b162230e8a07275043a888907
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: nit-picking [IOS] [MINOR] [React/Base/RCTModuleData.mm] - Fix markdown in `requiresMainQueueSetup` warning Closes facebook#16916 Differential Revision: D6394725 Pulled By: shergin fbshipit-source-id: 272c5a6ee529af0b162230e8a07275043a888907
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: nit-picking [IOS] [MINOR] [React/Base/RCTModuleData.mm] - Fix markdown in `requiresMainQueueSetup` warning Closes facebook#16916 Differential Revision: D6394725 Pulled By: shergin fbshipit-source-id: 272c5a6ee529af0b162230e8a07275043a888907
charpeni
deleted the
fix-markdown-in-requires-main-queue-setup-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
nit-picking
Release Notes
[IOS] [MINOR] [React/Base/RCTModuleData.mm] - Fix markdown in
requiresMainQueueSetupwarning