Packager linking when using custom debug configuration on iOS device #16451
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
|
@ZdravkoN I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
Hi @facebook-github-bot, yes, the pull request is still relevant. I will look at the changes made in master and update it. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
stale
bot
added
the
Stale
|
This is an important and simple fix. It can be merged straight away. If fixes a problem and it makes the script more consistent. The wildcards usage with Can someone help? Ping @davidaurelio, @javache |
stale
bot
removed
the
Stale
|
Thanks for sending this pull request! We would love to review your changes however it looks like you haven't signed the CLA yet. If you are still interested in supporting this PR, please sign the CLA by visiting https://code.facebook.com/cla. Let us know once you have done so. |
|
I have signed the CLA. Please re-open this pull request. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
This comment has been minimized.
This comment has been minimized.
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was closed by Zdravko Nikolovski in 079bf3f. Once this commit is added to a release, you will see the corresponding version tag below the description at 079bf3f. If the commit has a single |
hramos
removed
Import Started
Motivation
In many projects we have different environments that we connect to. For these environments (for example: Test, Staging, Production) we have custom configurations (Debug and Release). While this is not a problem on Android, it is a problem on iOS. With the current implementation of the react-native-xcode.sh script, when using a custom Debug configuration, the app started on iOS device, can't contact the Packager. This pull request solves this issue.
Test Plan
Connect a real device, start the app with a custom debug configuration in Xcode. Shake and Reload.
Release Notes
[IOS][BUGFIX][./scripts/react-native-xcode.sh] Add support for connecting to the Packager when running the iOS app on device when using custom Debug configuration.