Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Travis over to Circle #16354

Closed
wants to merge 15 commits into from
Closed

Migrate Travis over to Circle #16354

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1904114
First attempt, play around with beta
grabbou Oct 13, 2017
1ef2f88
Fix indent and use shared install_dependencies step
grabbou Oct 13, 2017
6299fb1
Comment out podspec tests temporarily to see if they pass on a non-PR…
grabbou Oct 13, 2017
672d634
Change OS version so CircleCI can run the test
grabbou Oct 13, 2017
14e4e3f
Remove Travis config
grabbou Oct 13, 2017
19837d0
Update some ifs
grabbou Oct 13, 2017
b97f1be
Fix wrong variable reference
grabbou Oct 13, 2017
a17e8e5
Cocoapods is already on Circle
grabbou Oct 13, 2017
b43e749
Comments and common test step
grabbou Oct 13, 2017
03f7aff
Prestart iOS simulator and run podspec tests on PRs as well
grabbou Oct 13, 2017
bf7dfde
Fix typo
grabbou Oct 13, 2017
a979ea8
Use node cache
grabbou Oct 13, 2017
684089d
Fix typos
grabbou Oct 13, 2017
4cf9f62
Update config.yml
hramos Oct 13, 2017
d751e1e
Update cache keys
hramos Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prestart iOS simulator and run podspec tests on PRs as well
  • Loading branch information
@grabbou
grabbou committed Oct 13, 2017
commit 03f7affa627414e5d7c729fcb74940baed93f9d1
18 changes: 11 additions & 7 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@ jobs:
<<: *defaults
macos:
xcode: "9.0"
dependencies:
pre:
- xcrun instruments -w "iPhone 5s (10.3.1)" || true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do this separately from this PR, but at some point we should switch over to iOS 11.0 here, and tvOS 11.0 in test-objc-tvos. This would match what we're testing internally.

steps:
- checkout
- run: *install_node_dependencies
Expand All @@ -146,6 +149,9 @@ jobs:
<<: *defaults
macos:
xcode: "9.0"
dependencies:
pre:
- xcrun instruments -w "Apple TV 1080p (10.0)" || true
steps:
- checkout
- run: *install_node_dependencies
Expand All @@ -156,6 +162,9 @@ jobs:
<<: *defaults
macos:
xcode: "9.0"
dependencies:
pre:
- xcrun instruments -w "iPhone 5s (10.3.1)" || true
steps:
- checkout
- run: *install_node_dependencies
Expand All @@ -169,12 +178,7 @@ jobs:
steps:
- checkout
- run: *install_node_dependencies
- run: |
if [ "$CI_PULL_REQUEST" ]; then
./scripts/process-podspecs.sh
else
echo "Skipping testing podspec."
fi
- run: ./scripts/process-podspecs.sh

test-website:
<<: *defaults
Expand Down Expand Up @@ -429,5 +433,5 @@ workflows:
jobs:
- test-objc-ios
- test-objc-tvos
- test-objc-e2e
- test-podspec
- test-objc-e2e