[iOS] Fixed onChange prop of textinput not be called in some cases

facebook · Feb 28, 2019 · f032e7a · f032e7a
1 parent fc91bcc
commit f032e7a
Showing 1 changed file with 20 additions and 10 deletions.
diff --git a/Libraries/Text/TextInput/RCTBaseTextInputView.m b/Libraries/Text/TextInput/RCTBaseTextInputView.m
@@ -392,6 +392,16 @@ - (BOOL)textInputShouldChangeTextInRange:(NSRange)range replacementText:(NSStrin
                                    notifyDelegate:YES];
 
         [self textInputDidChange];
+
+        _nativeEventCount++;
+
+        if (_onChange) {
+          _onChange(@{
+                      @"text": _predictedText,
+                      @"target": self.reactTag,
+                      @"eventCount": @(_nativeEventCount),
+                      });
+        }
       }
 
       return NO;
@@ -423,6 +433,16 @@ - (BOOL)textInputShouldChangeTextInRange:(NSRange)range replacementText:(NSStrin
       @"eventCount": @(_nativeEventCount),
     });
   }
+
+  _nativeEventCount++;
+
+  if (_onChange) {
+    _onChange(@{
+                @"text": _predictedText,
+                @"target": self.reactTag,
+                @"eventCount": @(_nativeEventCount),
+                });
+  }
 
   return YES;
 }
@@ -446,16 +466,6 @@ - (void)textInputDidChange
     [self textInputDidChangeSelection];
     _predictedText = backedTextInputView.attributedText.string;
   }
-
-  _nativeEventCount++;
-
-  if (_onChange) {
-    _onChange(@{
-       @"text": self.attributedText.string,
-       @"target": self.reactTag,
-       @"eventCount": @(_nativeEventCount),
-    });
-  }
 }
 
 - (void)textInputDidChangeSelection