refactor: increase useColorScheme subscription efficiency

facebook · Jun 21, 2023 · a887171 · a887171
1 parent 5f7c5a8
commit a887171
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/packages/react-native/Libraries/Utilities/useColorScheme.js b/packages/react-native/Libraries/Utilities/useColorScheme.js
@@ -13,14 +13,16 @@
 import type {ColorSchemeName} from './NativeAppearance';
 
 import Appearance from './Appearance';
-import {useSyncExternalStore} from 'react';
+import {useCallback, useSyncExternalStore} from 'react';
 
 export default function useColorScheme(): ?ColorSchemeName {
+  const subscribe = useCallback(callback => {
+    const appearanceSubscription = Appearance.addChangeListener(callback);
+    return appearanceSubscription.remove;
+  }, [])
+
   return useSyncExternalStore(
-    callback => {
-      const appearanceSubscription = Appearance.addChangeListener(callback);
-      return () => appearanceSubscription.remove();
-    },
-    () => Appearance.getColorScheme(),
+    subscribe,
+    Appearance.getColorScheme,
   );
 }