Skip to content

Commit

Permalink
remove outdated code in RCTNavigator
Browse files Browse the repository at this point in the history
Reviewed By: mmmulani

Differential Revision: D4095285

fbshipit-source-id: 1e2111b6647e14562675e4474cd56acb91d22ec2
  • Loading branch information
majak authored and Facebook Github Bot committed Nov 11, 2016
1 parent 4783930 commit a3ad34c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
1 change: 0 additions & 1 deletion React/Views/RCTNavigator.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

@interface RCTNavigator : UIView <RCTFrameUpdateObserver>

@property (nonatomic, strong) UIView *reactNavSuperviewLink;
@property (nonatomic, assign) NSInteger requestedTopOfStack;
@property (nonatomic, assign) BOOL interactivePopGestureEnabled;

Expand Down
11 changes: 0 additions & 11 deletions React/Views/RCTNavigator.m
Original file line number Diff line number Diff line change
Expand Up @@ -499,17 +499,6 @@ - (void)dispatchFakeScrollEvent
[_bridge.eventDispatcher sendFakeScrollEvent:self.reactTag];
}

/**
* Must be overridden because UIKit removes the view's superview when used
* as a navigator - it's considered outside the view hierarchy.
*/
- (UIView *)reactSuperview
{
RCTAssert(!_bridge.isValid || self.superview != nil, @"put reactNavSuperviewLink back");
UIView *superview = [super reactSuperview];
return superview ?: self.reactNavSuperviewLink;
}

- (void)reactBridgeDidFinishTransaction
{
// we can't hook up the VC hierarchy in 'init' because the subviews aren't
Expand Down

0 comments on commit a3ad34c

Please sign in to comment.