Fix RNTester warnings (#23584)

Summary:
Part of #22609. This brings the warning count down to 0 for the RNTester target, also adds a fancy new icon!

[General] [Fixed] - All RNTester warnings fixed
Pull Request resolved: #23584

Differential Revision: D14181197

Pulled By: cpojer

fbshipit-source-id: 4377a55cee6a2d87a7926f1c34663b8a070aef88

Libraries/LinkingIOS/RCTLinkingManager.m

@@ -56,6 +56,7 @@ + (BOOL)application:(UIApplication *)app
   return YES;
 }
 
+// Corresponding api deprecated in iOS 9
 + (BOOL)application:(UIApplication *)application
             openURL:(NSURL *)URL
   sourceApplication:(NSString *)sourceApplication

RNTester/RNTester/AppDelegate.m

@@ -61,13 +61,6 @@ - (BOOL)application:(UIApplication *)app
   return [RCTLinkingManager application:app openURL:url options:options];
 }
 
-- (BOOL)application:(UIApplication *)application openURL:(NSURL *)url
-  sourceApplication:(NSString *)sourceApplication annotation:(id)annotation
-{
-  return [RCTLinkingManager application:application openURL:url
-                      sourceApplication:sourceApplication annotation:annotation];
-}
-
 - (void)loadSourceForBridge:(RCTBridge *)bridge
                  onProgress:(RCTSourceLoadProgressBlock)onProgress
                  onComplete:(RCTSourceLoadBlock)loadCallback

RNTester/RNTester/Images.xcassets/AppIcon.appiconset/Contents.json

@@ -25,13 +25,13 @@
     {
       "size" : "40x40",
       "idiom" : "iphone",
-      "filename" : "[email protected]",
+      "filename" : "Icon-Small-[email protected]",
       "scale" : "2x"
     },
     {
       "size" : "40x40",
       "idiom" : "iphone",
-      "filename" : "[email protected]",
+      "filename" : "Icon-Small-[email protected]",
       "scale" : "3x"
     },
     {
@@ -47,8 +47,56 @@
       "scale" : "3x"
     },
     {
-      "idiom" : "ios-marketing",
+      "idiom" : "ipad",
+      "size" : "20x20",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "20x20",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "29x29",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "29x29",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "40x40",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "40x40",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "76x76",
+      "scale" : "1x"
+    },
+    {
+      "size" : "76x76",
+      "idiom" : "ipad",
+      "filename" : "[email protected]",
+      "scale" : "2x"
+    },
+    {
+      "size" : "83.5x83.5",
+      "idiom" : "ipad",
+      "filename" : "[email protected]",
+      "scale" : "2x"
+    },
+    {
       "size" : "1024x1024",
+      "idiom" : "ios-marketing",
+      "filename" : "[email protected]",
       "scale" : "1x"
     }
   ],