Skip to content

Commit

Permalink
Add upper case keys to the debug key handler (#45559)
Browse files Browse the repository at this point in the history
Summary:
The CLI of Metro bundler only accepts key presses when the Caps Lock is off. This is somehow inconvenient because the developers might think the Metro bundler doesn't response when the Caps Lock is on.

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[GENERAL] [ADDED] - Add upper case keys to the debug key handler

Pull Request resolved: #45559

Test Plan: n/a

Reviewed By: huntie

Differential Revision: D60107316

Pulled By: dmytrorykun

fbshipit-source-id: 045dcd382d84c4781dff75a1ff913cd3ccc8d288
  • Loading branch information
wh201906 authored and facebook-github-bot committed Jul 23, 2024
1 parent c24929c commit 6390cf6
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default function attachKeyHandlers({
};

const onPress = async (key: string) => {
switch (key) {
switch (key.toLowerCase()) {
case 'r':
logger.info('Reloading connected app(s)...');
messageSocket.broadcast('reload', null);
Expand Down

0 comments on commit 6390cf6

Please sign in to comment.