fix: give credit to Oskar for Swift template #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cipolleschi
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Thanks for the clarification!
This acknowledgments are usually to thanks people that contributed to writing part of the blogpost, more than to the actual credit for the practical work (credits given through commits in this case) but there is no harm in merging this.
|
Thank you! Happy to help next time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the work on the Swift template is credited to Riccardo only in 0.77 blog post. Since the bulk of work and prior art in React Native visionOS project was done by Oskar, I believe he deserves a little credit in that blog post :)