-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Docusaurus v3.2 #4072
Changes from all commits
fa9049f
c889fda
52a30ef
af5bf51
8065a80
a1e2185
a0fa632
c449740
af6fc16
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -208,6 +208,8 @@ export default App; | |
</TabItem> | ||
</Tabs> | ||
|
||
--- | ||
|
||
Comment on lines
+211
to
+212
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is due to the weird structure the RN website use for many bases, using a This is not semantically correct, and if it's only to apply a larger font it would be better to apply a different solution. I've made a little tweak to the heuristic Docusaurus uses to decide (or not) to add the front matter title at the top of the page (facebook/docusaurus#9999), so that I don't have to refactor the other docs as well, but this specific page wasn't covered because it's not consistent with the others and Note other docs are inconsistent:
I only fixed this case because it prevented the insertion of the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree that we should avoid using an additional |
||
# Reference | ||
|
||
## Props | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,15 +11,15 @@ The contributors who helped tackle the incident recently attended a post-mortem | |
|
||
<!--truncate--> | ||
|
||
# What happened | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Old blog post using h1 everywhere instead of h2 |
||
## What happened | ||
|
||
On November 4th 2022, we published the version `0.71.0-rc0` of React Native, the first release candidate for 0.71, on several public repositories. | ||
|
||
A major change made in this release candidate helped to improve build times by publishing artifacts to Maven Central, instead of building them from source. More details on how this was done are available in [RFC#508](https://github.com/react-native-community/discussions-and-proposals/pull/508) and [related discussions](https://github.com/reactwg/react-native-new-architecture/discussions/105). | ||
|
||
Unfortunately, because of the way we scaffolded new projects from the template, this caused build failures for any Android user on older versions because they would start downloading new artifacts for `0.71.0-rc0` instead of the version they were using in their project (like `0.68.0`). | ||
|
||
# Why this happened | ||
## Why this happened | ||
|
||
The React Native template provides a `build.gradle` file to build Android apps. This file contains a dependency on the React Native Android library as follows: | ||
`implementation("com.facebook.react:react-native:+")`. | ||
|
@@ -32,7 +32,7 @@ This caused builds with React Native versions before `0.71.0-rc.0` to query all | |
|
||
Further technical details on this event area are also available [on this GitHub issue](https://github.com/facebook/react-native/issues/35210). | ||
|
||
# How we mitigated & resolved | ||
## How we mitigated & resolved | ||
|
||
As soon as we identified the issue on November 4th, the community found and shared a manual workaround to fix the issue which would pin React Native to a specific, correcting the mistake. | ||
|
||
|
@@ -42,7 +42,7 @@ At the same time, we [reached out to Sonatype](https://issues.sonatype.org/brows | |
|
||
The issue was fully resolved on November 8th when the artifacts were fully removed from Maven Central. | ||
|
||
# Timeline of events | ||
## Timeline of events | ||
|
||
_This section contains a brief timeline of the events. All times are GMT/UTC +0_ | ||
|
||
|
@@ -58,7 +58,7 @@ _This section contains a brief timeline of the events. All times are GMT/UTC +0_ | |
- Nov 8th - 08:04 PM: Artifacts on Maven Central are [fully removed](https://issues.sonatype.org/browse/OSSRH-86006?focusedCommentId=1216303&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1216303). | ||
- Nov 10th - 11:51 AM: Issue about the [incident is closed](https://github.com/facebook/react-native/issues/35210#issuecomment-1310170361). | ||
|
||
# Lessons Learned | ||
## Lessons Learned | ||
|
||
While in many ways the conditions to trigger this incident has existed since React Native 0.12.0, we want to ensure that the foundations on which we develop and release React Native moving forward are stronger. Here are some of the lessons learned and the actionables on how we’ll adapt our processes and infrastructure to respond faster and stronger in the future. | ||
|
||
|
@@ -94,7 +94,7 @@ Specifically, we are now encouraging and supporting 3rd party library testing as | |
|
||
On top of this, we started a closer collaboration with Callstack, the maintainers of [create-react-native-library](https://github.com/callstack/react-native-builder-bob/tree/main/packages/create-react-native-library), to improve the library template and make sure it follows all the necessary best practices to integrate with React Native projects. The newer version of `create-react-native-library` is now fully compatible with 0.71 projects while still offering backward compatibility. | ||
|
||
# Conclusions | ||
## Conclusions | ||
|
||
We want to apologize for the disruption this caused to the workflows of developers all around the world. As highlighted above, we have already started taking action to strengthen our foundation - and more work is due. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -219,6 +219,9 @@ module.exports = { | |
defaultLanguage: 'jsx', | ||
theme: require('./core/PrismTheme'), | ||
additionalLanguages: [ | ||
'diff', | ||
'bash', | ||
'json', | ||
Comment on lines
+222
to
+224
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. required by v3.0+ (non beta) |
||
'java', | ||
'kotlin', | ||
'objectivec', | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -625,7 +625,7 @@ a[class*="tagRegular"] { | |
} | ||
} | ||
|
||
.navbar__items div[class^="searchBox"] { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. little CSS class rename on our side |
||
.navbar__items div[class^="navbarSearchContainer"] { | ||
padding-left: 14px; | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,6 +98,8 @@ const styles = StyleSheet.create({ | |
export default App; | ||
``` | ||
|
||
--- | ||
|
||
# Reference | ||
|
||
## Props | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -209,6 +209,8 @@ export default App; | |
</TabItem> | ||
</Tabs> | ||
|
||
--- | ||
|
||
# Reference | ||
|
||
## Props | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -208,6 +208,8 @@ export default App; | |
</TabItem> | ||
</Tabs> | ||
|
||
--- | ||
|
||
# Reference | ||
|
||
## Props | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -208,6 +208,8 @@ export default App; | |
</TabItem> | ||
</Tabs> | ||
|
||
--- | ||
|
||
# Reference | ||
|
||
## Props | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The broken link checker is now case sensitive because some hosting platforms are case sensitive too and can't serve
hermes.html
from/HeRMeS