Update native-modules-android.md

[simonbrunou]

Those two methods are missing in the documentation and an exception is sent if they are not in the code.

[facebook-github-bot]

Hi @simonbrunou!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[netlify]

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: 8cd30cc

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/615c74708fc8ef0007dc1588

😎 Browse the preview: https://deploy-preview-2791--react-native.netlify.app

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[satya164]

Can you post what exception you got and share a link to the native module which implemented this?

[simonbrunou]

When omitting addListener, this is the exception:

`new NativeEventEmitter()` was called with a non-null argument without the required `addListener` method.

When omitting removeListeners, this is the exception:

`new NativeEventEmitter()` was called with a non-null argument without the required `removeListeners` method.

I cannot share a link to the native module which implemented this when I was confronted with the problem as it is proprietary source code. However I can put together a file that implements it quickly, if needed.

[rubennorte]

Thanks @simonbrunou for improving our docs! This was definitely incomplete without the examples that you added. Can you please address my comment so we can merge it? Thanks!

[simonbrunou]

Thanks @simonbrunou for improving our docs! This was definitely incomplete without the examples that you added. Can you please address my comment so we can merge it? Thanks!

I think it's done, however I'm not familiar with GitHub's interface so correct me if I did something wrong.

[Simek]

Hi @simonbrunou, thank you for bringing this topic up! 👍

Since the change landed in 0.65 release (facebook/react-native@114be1d), please update also versioned docs for 0.65 and 0.66 besides the next file:

• https://github.com/facebook/react-native-website#versioned-docs

[simonbrunou]

I rebased on main and added the changes to the documentation.

[Simek]

It looks like you did not force push after rebase, which leads to malformed PR, please fix that. 😉

[simonbrunou]

It should be good now.

[Simek]

Thank you for the updates! 👍

From the technical standpoint it LGTM, but let's wait with the merge for the @rubennorte approval on the wording/description changes. 🙂

[rubennorte]

I think we can still improve the comment. I don't think the current one is useful to tell people what this is for, only that's required. We could say something like what we say on iOS.

So instead of:

 // Keep: Required for RN built in Event Emitter Calls.

We could use something like:

@ReactMethod
public void addListener(String eventName) {
  // Set up any upstream listeners or background tasks as necessary
}

@ReactMethod
public void removeListeners(Integer count) {
  // Remove upstream listeners, stop unnecessary background tasks
}

@simonbrunou could you please make these changes? Sorry for the back and forth.

[simonbrunou]

Updated the files 👍

[rubennorte]

Thanks for improving our website, @simonbrunou!