Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope down Network panel features for React Native #154

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

huntie
Copy link
Member

@huntie huntie commented Mar 4, 2025

Summary

Disables and scopes down various parts of the Network panel UI when Root.Runtime.ExperimentName.REACT_NATIVE_SPECIFIC_UI is set.

Removes:

  • Web-only concepts
    • Filters: Hide extension URLs, Blocked request cookies, 3rd party requests
    • Resource category filters: Document, Stylesheet, Font, Manifest, Websocket, Wasm
  • Features we don't plan to implement in our first pass
    • Network conditions (throttling)
    • Screenshot capture

Additionally, opts into the NETWORK_PANEL_FILTER_BAR_REDESIGN experiment for our react_fusebox.ts entry point — aiming to minimise code forks under maintenance.

Test plan

Before

Screenshot 2025-03-04 at 14 20 49

After

image

ℹ️ NETWORK_PANEL_FILTER_BAR_REDESIGN is enabled, moving the filter options into two dropdowns.
✅ Features hidden
✅ Resource categories limited


  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@huntie huntie merged commit 17895f4 into facebook:main Mar 5, 2025
2 of 3 checks passed
@huntie huntie deleted the network-disable-features branch March 5, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants