Fix reload action (regression in #144) #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix reload behaviour for React Native targets. This regressed in the
chromium/6613
sync (#144) due to stricter page reload logic.It turns out,
ResourceTreeModel
is completely bypassed for Node/React Native targets, since they don't haveCapability.DOM
(and calling the thereloadPage
method in this way is unpredictable behaviour). We now explicitly fork this logic for React Native.Test plan
Reload (
cmd
+R
)cmd
+R
from anywhere in DevTools.Screen.Recording.2025-02-28.at.10.56.18.mov
Reload to profile
Screen.Recording.2025-02-28.at.11.34.26.mov
Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.