Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate upload-artifact GitHub Action to v4 from v3 #148

Merged

Conversation

EdmondChuiHW
Copy link

@EdmondChuiHW EdmondChuiHW commented Feb 4, 2025

Summary

CI in this repo has been failing since Jan 30, 2025.

This PR makes the migration as detailed: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

Test plan

Tests now run. They're failing, but they run. To be investigated in follow-ups

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@EdmondChuiHW EdmondChuiHW force-pushed the v4-github-action-upload-artifact branch from 7b2102f to fe4d300 Compare February 5, 2025 17:29
@EdmondChuiHW EdmondChuiHW marked this pull request as ready for review February 5, 2025 19:41
@EdmondChuiHW EdmondChuiHW force-pushed the v4-github-action-upload-artifact branch from fe4d300 to 3f67bee Compare February 5, 2025 19:59
@EdmondChuiHW EdmondChuiHW merged commit a880a6f into facebook:main Feb 5, 2025
1 of 2 checks passed
@EdmondChuiHW EdmondChuiHW deleted the v4-github-action-upload-artifact branch February 5, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants