FB8-128: track Semisync_ack Engine_commit time in slow query log #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Summary: Closes facebook#681 Originally Reviewed By: lth Pulled By: francoisrichard fbshipit-source-id: e74d0cc
|
|
||
| # Check if Semisync_ack_time is included in slow log results | ||
| --let SEARCH_PATTERN= Semisync_ack_time: | ||
| --source include/search_pattern_in_file.inc |
There was a problem hiding this comment.
Can there be a pre-existing slow log, resulting in false positives?
There was a problem hiding this comment.
This feature is compiled inside a server so all comments in slow log should have "Semisync_ack_time" or none. For this case "--repeat" doesn't matter.
inikep
changed the title
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
approved these changes
Mar 21, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 25, 2019
Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: 2dd16b3 Reference Pull: #681 Originally Reviewed By: lth Pull Request resolved: #982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: 545ec96
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: 2dd16b3 Reference Pull: #681 Originally Reviewed By: lth Pull Request resolved: #982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: e36ce7f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 21, 2020
…ebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: e36ce7f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 23, 2020
…ebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: e36ce7f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
…ebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: e36ce7f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
…ebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: e36ce7f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 29, 2020
…ebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: e36ce7f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
…ebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: e36ce7f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
…ebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: e36ce7f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 7, 2020
…ebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: e36ce7f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
…ebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: e36ce7f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
…ebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lth Differential Revision: D14421316 Pulled By: lth fbshipit-source-id: e36ce7f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 11, 2021
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 (facebook@29729c9) Pulled By: lth fbshipit-source-id: 8ec16de3049
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 15, 2021
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 (facebook@29729c9) Pulled By: lth fbshipit-source-id: 8ec16de3049
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
…cona#982) (percona#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook/mysql-5.6@2dd16b3 Reference Pull: facebook/mysql-5.6#681 Originally Reviewed By: lth Pull Request resolved: facebook/mysql-5.6#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 25, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 20, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 21, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 25, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 2, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
…ebook#982) (facebook#982) Summary: Jira issue: https://jira.percona.com/browse/FB8-128 Reference Patch: facebook@2dd16b3 Reference Pull: facebook#681 Originally Reviewed By: lth Pull Request resolved: facebook#982 Reviewed By: lloyd Differential Revision: D14421316 Pulled By: lth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: https://jira.percona.com/browse/FB8-128
Reference Patch: 2dd16b3
Closes #681
Originally Reviewed By: lth