FB8-47 : Increase max user name length to 80 #937

satya-bodapati · 2019-01-23T12:37:15Z

https://jira.percona.com/browse/FB8-47

The max user name length is increased to 80 chars (utf8mb3)
Since the system tables are InnoDB tables and because Primary key is
on the full username (80 *3 = 240 bytes) and other columns, InnoDb
initialization with 4k page size fails.

This is new limitation.

Reference Patch: 3dbbcfc

This mitigates upstream bug: http://bugs.mysql.com/3083

User name length limit of 16 was too short, so made it 80.

80 is effectively the limit without making additional changes
because of MyISAM's 1000 byte limit on key length and the
primary key of mysql.columns_priv. To compute the size of
the key for that table, the lengths of the char fields are
summed and then multipled by 3, resulting in a limit on the
max size of user name lengths being 81 characters.

Test Plan:
Added long user names to basic grant and replication tests.

Did full build and test run without perfschema, no failures.

Did full build and test run with perfschema, no new failures.

Jenkins both 'arc unit', and 'arc unit --everything', pass

Built a test rpm, ran it through rpm tests, passed.

Installed the test rpm on a test server, then downgraded it:
"use mysql; show create table user;", and got:

Before upgrade: "...User char(16)..."
After upgrade: "...User char(16)..."
After restart: "...User char(16)..."
After running mysql_upgrade: "...User char(80)..."
After downgrade: "...User char(80)..."
After restart: "...User char(80)..."
After running mysql_upgrade: "...User char(16)..."

satya-bodapati · 2019-01-23T12:48:33Z

https://ps.cd.percona.com/view/8.0/job/percona-server-8.0-param/191/

include/mysql/components/services/psi_thread_bits.h

include/mysql/plugin_auth.h.pp

include/mysql/plugin_auth_common.h

include/mysql/psi/psi_abi_thread_v1.h.pp

satya-bodapati · 2019-01-24T11:56:21Z

Fix testcases that failed from jenkins run. Lot of result content mismatches to user length change

mysql-test/t/dd_upgrade_partition.test

sql/log_event.cc

percona-ysorokin · 2019-01-24T13:01:05Z

Also, please include Jira ticket URL into the commit message.

percona-ysorokin

LGTM with formatting issues addressed and commit message extended with Jira ticket URL.

facebook-github-bot

@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

hermanlee

I'm seeing failures in main.dd_schema_definition_after_upgrade_debug and main.dictionary_tablespace for the debug builds after importing this patch.

They both report back the following errors in the error log. dd_schema_definition_after_upgrade_debug also crashes the mysqld server.

2019-02-01T00:42:53.091758Z 0 [ERROR] [MY-013139] [Server] Cannot load from mysql.db. The table is probably corrupted!
2019-02-01T00:42:53.091799Z 0 [ERROR] [MY-013139] [Server] Cannot load from mysql.tables_priv. The table is probably corrupted!
2019-02-01T00:42:53.091824Z 0 [ERROR] [MY-013139] [Server] Cannot load from mysql.columns_priv. The table is probably corrupted!
2019-02-01T00:42:53.091843Z 0 [ERROR] [MY-013139] [Server] Cannot load from mysql.procs_priv. The table is probably corrupted!
2019-02-01T00:42:53.091862Z 0 [ERROR] [MY-013139] [Server] Cannot load from mysql.proxies_priv. The table is probably corrupted!
.... repeated 1 times: [ERROR] [MY-013139] [Server] Cannot load from mysql.proxies_priv. The table is probably corrupted!
2019-02-01T00:42:53.811610Z 9 [ERROR] [MY-013139] [Server] Cannot load from mysql.db. The table is probably corrupted!
2019-02-01T00:42:53.811636Z 9 [ERROR] [MY-013139] [Server] Cannot load from mysql.tables_priv. The table is probably corrupted!
2019-02-01T00:42:53.811660Z 9 [ERROR] [MY-013139] [Server] Cannot load from mysql.columns_priv. The table is probably corrupted!
2019-02-01T00:42:53.811676Z 9 [ERROR] [MY-013139] [Server] Cannot load from mysql.procs_priv. The table is probably corrupted!
2019-02-01T00:42:53.811689Z 9 [ERROR] [MY-013139] [Server] Cannot load from mysql.proxies_priv. The table is probably corrupted!
.... repeated 1 times: [ERROR] [MY-013139] [Server] Cannot load from mysql.proxies_priv. The table is probably corrupted!

satya-bodapati · 2019-02-01T15:02:46Z

@hermanlee

Let me check on how these test failures are missed from my Jenkins test failure analysis.

main.dictionary_tablespace:
Upgrade from 5.7 to 8.0 will result in additional warnings, these are caused because the system tables have different schema in 5.7 and 8.0. (Upstream have same schema and so they don't get the warnings).

These warnings are fine and later mysql_upgrade fixes the schema of system tables.

dd_schema_definition_after_upgrade_debug:
This is because we have 8.0.11 and 8.0.12 zipped mysql datadir that are run against FB 8.0.13 with different system tables schema. I think a proper upgrade of schema tables is not handled between minor version (8.0.11->8.0.12->8.0.13).

To fix this test, we should fix code to handle system tables with different schema . This is happening with upgrade from 5.7 to 8.0 only.

satya-bodapati · 2019-02-04T05:30:51Z

@hermanlee some questions to you

Do you care about upgrade from FB 8.0.11/12 to FB 8.0.13 (assuming you have FB 8.0.11/12 branches)?
Should I fix this 8.0 upgrade issue now? or create a separate issue with low priority?
If answer to question is create separate issue, I will disable part of the test (8.0 allows disabling part of test, may be introduced in 8.0.13 or .14 release).

hermanlee · 2019-02-04T14:33:26Z

@satya-bodapati We don't care about from 8.0.11/12 to the latest, so disabling these tests and filing a low priority issue to resolve this later would work.

satya-bodapati · 2019-02-05T01:01:30Z

Created JIRA issue https://jira.percona.com/browse/FB8-220 to handle 8.0 upgrades.

With 8.0.13, there is no need to disable entire test. I will try to disable the relevant part of the test only in dd_schema_definition_after_upgrade_debug

JIRA issue: https://jira.percona.com/browse/FB8-47 Reference patch: facebook@3dbbcfc The max user name length is increased to 80 chars (utf8mb3) Since the system tables are InnoDB tables and because Primary key is on the full username (80 *3 = 240 bytes) and other columns, InnoDB initialization with 4k page size fails. This is new limitation. ---------- facebook@3dbbcfc -------- Summary: This mitigates upstream bug: http://bugs.mysql.com/3083 User name length limit of 16 was too short, so made it 80. 80 is effectively the limit without making additional changes because of MyISAM's 1000 byte limit on key length and the primary key of mysql.columns_priv. To compute the size of the key for that table, the lengths of the char fields are summed and then multipled by 3, resulting in a limit on the max size of user name lengths being 81 characters. Test Plan: Added long user names to basic grant and replication tests. Did full build and test run without perfschema, no failures. Did full build and test run with perfschema, no new failures. Jenkins both 'arc unit', and 'arc unit --everything', pass Built a test rpm, ran it through rpm tests, passed. Installed the test rpm on a test server, then downgraded it: "use mysql; show create table user;", and got: * Before upgrade: "...`User` char(16)..." * After upgrade: "...`User` char(16)..." * After restart: "...`User` char(16)..." * After running mysql_upgrade: "...`User` char(80)..." * After downgrade: "...`User` char(80)..." * After restart: "...`User` char(80)..." * After running mysql_upgrade: "...`User` char(16)..." Originally Reviewed By: santoshb

facebook-github-bot · 2019-02-05T01:58:19Z

@satya-bodapati has updated the pull request. Re-import the pull request

satya-bodapati · 2019-02-05T01:59:40Z

Used --disable_testcase and --enable_testcase to disable only 8.0.11/12 upgrade parts in dd_schema_definition_after_upgrade_debug and added supression for dictionary_tablespace test.

satya-bodapati · 2019-02-05T01:59:48Z

Updated the patch

facebook-github-bot

@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: https://jira.percona.com/browse/FB8-47 The max user name length is increased to 80 chars (utf8mb3) Since the system tables are InnoDB tables and because Primary key is on the full username (80 *3 = 240 bytes) and other columns, InnoDb initialization with 4k page size fails. This is new limitation. Reference Patch: 3dbbcfc This mitigates upstream bug: http://bugs.mysql.com/3083 User name length limit of 16 was too short, so made it 80. 80 is effectively the limit without making additional changes because of MyISAM's 1000 byte limit on key length and the primary key of mysql.columns_priv. To compute the size of the key for that table, the lengths of the char fields are summed and then multipled by 3, resulting in a limit on the max size of user name lengths being 81 characters. Pull Request resolved: #937 Reviewed By: lth Differential Revision: D13890369 Pulled By: lth fbshipit-source-id: 347fef4

…#937) Summary: https://jira.percona.com/browse/FB8-47 The max user name length is increased to 80 chars (utf8mb3) Since the system tables are InnoDB tables and because Primary key is on the full username (80 *3 = 240 bytes) and other columns, InnoDb initialization with 4k page size fails. This is new limitation. Reference Patch: facebook@3dbbcfc This mitigates upstream bug: http://bugs.mysql.com/3083 User name length limit of 16 was too short, so made it 80. 80 is effectively the limit without making additional changes because of MyISAM's 1000 byte limit on key length and the primary key of mysql.columns_priv. To compute the size of the key for that table, the lengths of the char fields are summed and then multipled by 3, resulting in a limit on the max size of user name lengths being 81 characters. Pull Request resolved: facebook#937 Reviewed By: lloyd Differential Revision: D13890369 Pulled By: lth

Summary: https://jira.percona.com/browse/FB8-47 The max user name length is increased to 80 chars (utf8mb3) Since the system tables are InnoDB tables and because Primary key is on the full username (80 *3 = 240 bytes) and other columns, InnoDb initialization with 4k page size fails. This is new limitation. Reference Patch: facebook/mysql-5.6@3dbbcfc This mitigates upstream bug: http://bugs.mysql.com/3083 User name length limit of 16 was too short, so made it 80. 80 is effectively the limit without making additional changes because of MyISAM's 1000 byte limit on key length and the primary key of mysql.columns_priv. To compute the size of the key for that table, the lengths of the char fields are summed and then multipled by 3, resulting in a limit on the max size of user name lengths being 81 characters. Pull Request resolved: facebook/mysql-5.6#937 Reviewed By: lloyd Differential Revision: D13890369 Pulled By: lth

…#937) Summary: https://jira.percona.com/browse/FB8-47 The max user name length is increased to 80 chars (utf8mb3) Since the system tables are InnoDB tables and because Primary key is on the full username (80 *3 = 240 bytes) and other columns, InnoDb initialization with 4k page size fails. This is new limitation. Reference Patch: facebook@3dbbcfc This mitigates upstream bug: http://bugs.mysql.com/3083 User name length limit of 16 was too short, so made it 80. 80 is effectively the limit without making additional changes because of MyISAM's 1000 byte limit on key length and the primary key of mysql.columns_priv. To compute the size of the key for that table, the lengths of the char fields are summed and then multipled by 3, resulting in a limit on the max size of user name lengths being 81 characters. Pull Request resolved: facebook#937 Reviewed By: lloyd Differential Revision: D13890369 Pulled By: lth

… (facebook#937) Summary: https://jira.percona.com/browse/FB8-47 The max user name length is increased to 80 chars (utf8mb3) Since the system tables are InnoDB tables and because Primary key is on the full username (80 *3 = 240 bytes) and other columns, InnoDb initialization with 4k page size fails. This is new limitation. Reference Patch: facebook@3dbbcfc This mitigates upstream bug: http://bugs.mysql.com/3083 User name length limit of 16 was too short, so made it 80. 80 is effectively the limit without making additional changes because of MyISAM's 1000 byte limit on key length and the primary key of mysql.columns_priv. To compute the size of the key for that table, the lengths of the char fields are summed and then multipled by 3, resulting in a limit on the max size of user name lengths being 81 characters. Pull Request resolved: facebook#937 Reviewed By: lloyd Differential Revision: D13890369 Pulled By: lth

facebook-github-bot added the CLA Signed label Jan 23, 2019

percona-ysorokin reviewed Jan 23, 2019

View reviewed changes

include/mysql/components/services/psi_thread_bits.h Show resolved Hide resolved

include/mysql/plugin_auth.h.pp Show resolved Hide resolved

include/mysql/plugin_auth_common.h Show resolved Hide resolved

include/mysql/psi/psi_abi_thread_v1.h.pp Show resolved Hide resolved

satya-bodapati force-pushed the fb8-47 branch from f7d4f83 to 7f94ea7 Compare January 24, 2019 11:55

percona-ysorokin reviewed Jan 24, 2019

View reviewed changes

mysql-test/t/dd_upgrade_partition.test Show resolved Hide resolved

sql/log_event.cc Show resolved Hide resolved

percona-ysorokin approved these changes Jan 24, 2019

View reviewed changes

satya-bodapati changed the title ~~WIP: FB8-47 : Increase max user name length to 80~~ FB8-47 : Increase max user name length to 80 Jan 25, 2019

facebook-github-bot reviewed Jan 31, 2019

View reviewed changes

hermanlee approved these changes Feb 1, 2019

View reviewed changes

hermanlee requested changes Feb 1, 2019

View reviewed changes

satya-bodapati force-pushed the fb8-47 branch from 7f94ea7 to 8a37b97 Compare February 5, 2019 01:58

facebook-github-bot reviewed Feb 5, 2019

View reviewed changes

hermanlee approved these changes Feb 5, 2019

View reviewed changes

hermanlee closed this Feb 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FB8-47 : Increase max user name length to 80 #937

FB8-47 : Increase max user name length to 80 #937

satya-bodapati commented Jan 23, 2019 •

edited by hermanlee

Loading

satya-bodapati commented Jan 23, 2019

satya-bodapati commented Jan 24, 2019

percona-ysorokin commented Jan 24, 2019

percona-ysorokin left a comment

facebook-github-bot left a comment

facebook-github-bot left a comment

hermanlee left a comment

satya-bodapati commented Feb 1, 2019

satya-bodapati commented Feb 4, 2019

hermanlee commented Feb 4, 2019

satya-bodapati commented Feb 5, 2019

facebook-github-bot commented Feb 5, 2019

satya-bodapati commented Feb 5, 2019

satya-bodapati commented Feb 5, 2019

facebook-github-bot left a comment

FB8-47 : Increase max user name length to 80 #937

FB8-47 : Increase max user name length to 80 #937

Conversation

satya-bodapati commented Jan 23, 2019 • edited by hermanlee Loading

satya-bodapati commented Jan 23, 2019

satya-bodapati commented Jan 24, 2019

percona-ysorokin commented Jan 24, 2019

percona-ysorokin left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

hermanlee left a comment

Choose a reason for hiding this comment

satya-bodapati commented Feb 1, 2019

satya-bodapati commented Feb 4, 2019

hermanlee commented Feb 4, 2019

satya-bodapati commented Feb 5, 2019

facebook-github-bot commented Feb 5, 2019

satya-bodapati commented Feb 5, 2019

satya-bodapati commented Feb 5, 2019

facebook-github-bot left a comment

Choose a reason for hiding this comment

satya-bodapati commented Jan 23, 2019 •

edited by hermanlee

Loading