Skip trailing space bytes for non-unpackable fields #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanlee
approved these changes
Jan 10, 2018
There was a problem hiding this comment.
@lth has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This is a fantastic turn-around. I will cherry-pick this in immediately to avoid our normal merge lag. Thanks guys! |
|
@lth has updated the pull request. |
|
@lth has updated the pull request. |
|
@lth has updated the pull request. |
There was a problem hiding this comment.
@lth has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 16, 2018
Upstream commit ID : fb-mysql-5.6.35/f3d36951a62aa1a00a5a10083fb77e9919022e03 Cherry picked directly. Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes percona#784 Closes facebook/mysql-5.6#785 Differential Revision: D6699483 fbshipit-source-id: fd5c9d6
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 20, 2018
Upstream commit ID : fb-mysql-5.6.35/f3d36951a62aa1a00a5a10083fb77e9919022e03 MYR-232 : rocksdb: crash & corruption, charsets, indexed cols Cherry picked directly. Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes percona#784 Closes facebook/mysql-5.6#785 Differential Revision: D6699483 fbshipit-source-id: fd5c9d6
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 23, 2019
Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes #784 Closes #785 Differential Revision: D6699483 fbshipit-source-id: d0e042c
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 12, 2020
Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 fbshipit-source-id: d0e042c
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 fbshipit-source-id: d0e042c
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 16, 2020
Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 fbshipit-source-id: d0e042c
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 fbshipit-source-id: d0e042c
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Nov 11, 2020
Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 fbshipit-source-id: d0e042c
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 8, 2021
Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes #784 Closes #785 Differential Revision: D6699483 (f3d3695) fbshipit-source-id: 7707a3173f7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 16, 2021
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 (facebook@f3d3695) fbshipit-source-id: 7707a3173f7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 17, 2021
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 (facebook@f3d3695) fbshipit-source-id: 7707a3173f7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 (facebook@f3d3695) fbshipit-source-id: 7707a3173f7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 (facebook@f3d3695) fbshipit-source-id: 7707a3173f7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 31, 2021
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 (facebook@f3d3695) fbshipit-source-id: 7707a3173f7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 1, 2021
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 (facebook@f3d3695) fbshipit-source-id: 7707a3173f7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 2, 2021
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483 (facebook@f3d3695) fbshipit-source-id: 7707a3173f7
hermanlee
pushed a commit
that referenced
this pull request
Jan 10, 2022
Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes #784 Closes #785 Differential Revision: D6699483
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…rcona#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes percona#784 Closes facebook/mysql-5.6#785 Differential Revision: D6699483
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 20, 2022
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 23, 2022
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483
laurynas-biveinis
pushed a commit
to laurynas-biveinis/mysql-5.6
that referenced
this pull request
Aug 11, 2022
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 25, 2023
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 28, 2023
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
…acebook#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes facebook#784 Closes facebook#785 Differential Revision: D6699483
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
…rcona#785) Summary: We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes. Closes percona#784 Closes facebook/mysql-5.6#785 Differential Revision: D6699483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always generate unpack info bytes that indicate how much trailing space we need, even when the field can never be unpacked, because it is not implemented. When skipping these fields however, we only skip the key portion, and not the value portion which corrupts data for code that reads unpack_info downstream. Fix by skipping these bytes.
Closes #784