Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global variable max_nonsuper_connections #389

Closed

Conversation

tianx
Copy link
Member

@tianx tianx commented Nov 3, 2016

Summary:
The new global variable max_nonsuper_connections will enforce the limit for
the sum of all non-admin connections. This will be useful to limit regular user
connections while still allow super users to connect to server.

Test Plan:
mtr max_nonsuper_connections.test and sys_vars tests.

@facebook-github-bot
Copy link

@tianx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@tianx tianx force-pushed the max_total_user_connections branch from ed282b2 to 3c4dc52 Compare November 3, 2016 07:32
@facebook-github-bot
Copy link

@tianx updated the pull request - view changes - changes since last import

@tianx tianx force-pushed the max_total_user_connections branch from 3c4dc52 to 2f07838 Compare November 4, 2016 15:40
@facebook-github-bot
Copy link

@tianx updated the pull request - view changes - changes since last import

@tianx tianx force-pushed the max_total_user_connections branch from 2f07838 to 21b4b8d Compare November 4, 2016 17:15
@facebook-github-bot
Copy link

@tianx updated the pull request - view changes - changes since last import

@tianx tianx force-pushed the max_total_user_connections branch from 21b4b8d to a0a68cc Compare November 5, 2016 05:02
@facebook-github-bot
Copy link

@tianx updated the pull request - view changes - changes since last import

@tianx
Copy link
Member Author

tianx commented Nov 5, 2016

This PR is ready for review.

@tianx tianx force-pushed the max_total_user_connections branch from a0a68cc to 1b9c6fc Compare November 7, 2016 17:50
@facebook-github-bot
Copy link

@tianx updated the pull request - view changes - changes since last import

@tianx tianx force-pushed the max_total_user_connections branch from 1b9c6fc to ea9cc6c Compare November 7, 2016 23:04
@facebook-github-bot
Copy link

@tianx updated the pull request - view changes - changes since last import

@tianx tianx changed the title Add global variable max_total_user_connections Add global variable max_total_nonsuper_user_connections Nov 7, 2016
@tianx
Copy link
Member Author

tianx commented Nov 7, 2016

Make it explicit that the limit is enforced on nonsuper users.

@tianx tianx force-pushed the max_total_user_connections branch from ea9cc6c to 7646653 Compare November 7, 2016 23:44
@facebook-github-bot
Copy link

@tianx updated the pull request - view changes - changes since last import

@tianx tianx force-pushed the max_total_user_connections branch from 7646653 to be566db Compare November 7, 2016 23:46
@facebook-github-bot
Copy link

@tianx updated the pull request - view changes - changes since last import

@tianx tianx changed the title Add global variable max_total_nonsuper_user_connections Add global variable max_nonsuper_connections Nov 7, 2016
Summary:
The new global variable `max_nonsuper_connections` will enforce the limit for
the sum of all non-admin connections. This will be useful to limit regular user
connections while still allow super users to connect to server.

Test Plan:
mtr max_nonsuper_connections.test and sys_vars tests.
@tianx tianx force-pushed the max_total_user_connections branch from be566db to 3dc7050 Compare November 8, 2016 01:56
@facebook-github-bot
Copy link

@tianx updated the pull request - view changes - changes since last import

@tianx tianx deleted the max_total_user_connections branch November 8, 2016 05:58
abhinav04sharma pushed a commit to abhinav04sharma/mysql-5.6 that referenced this pull request Dec 6, 2016
Summary:
The new global variable `max_nonsuper_connections` will enforce the limit for
the sum of all non-admin connections. This will be useful to limit regular user
connections while still allow super users to connect to server.
Closes facebook#389
Github Author: Tian Xia <[email protected]>

Github PR Sync: {sync, type="child", parent="github", parentrepo="facebook/mysql-5.6", parentprnum="389", parentprfbid="333592887017230"}

Test Plan:

mtr max_nonsuper_connections.test and sys_vars tests.

Reviewers: arahut, anca, svcscm

Reviewed By: anca, svcscm

Subscribers: svcscm, ebergen, webscalesql-eng@

Differential Revision: https://phabricator.intern.facebook.com/D4123732

Tasks: 14204602

Signature: t1:4123732:1478568243:49c33f511fdbf72c5badccef652e9c8852f82842
hermanlee pushed a commit that referenced this pull request Jan 31, 2017
Summary:
The new global variable `max_nonsuper_connections` will enforce the limit for
the sum of all non-admin connections. This will be useful to limit regular user
connections while still allow super users to connect to server.
Closes #389

Reviewed By: anca-agape

Differential Revision: D4123732

Pulled By: tianx

fbshipit-source-id: 7ffb140
VitaliyLi pushed a commit to VitaliyLi/mysql-5.6 that referenced this pull request Feb 9, 2017
Summary:
The new global variable `max_nonsuper_connections` will enforce the limit for
the sum of all non-admin connections. This will be useful to limit regular user
connections while still allow super users to connect to server.
Closes facebook#389

Reviewed By: anca-agape

Differential Revision: D4123732

Pulled By: tianx

fbshipit-source-id: 7ffb140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants