Permissions for replay binlog for a read only database #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percona-ysorokin
suggested changes
Jan 20, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: commit 2eeee2cad2786227213f248158738eb8470cba0f Author: Zhicheng Zhu <[email protected]> Date: Tue Oct 29 10:20:47 2019 -0700 Extend repal_slave + admin_port to set gtid_next when repaly binlog Summary: Currently 8.0 mysqlbinlog will auto print set @session.next_gtid = 'automatic'. This will cause olm fix fail in 5.6. Extending the repal_slave + admin_port to unblock olm. Originally Reviewed By: yoshinorim fbshipit-source-id: 34f0a79 commit 30f5d8f273609dd95245f0a6f3cf36fe8dda3726 Author: Zhicheng Zhu <[email protected]> Date: Fri Sep 13 12:51:10 2019 -0700 let admin_port + repl_slave bypass read only database Summary: As the title said, this is the diff for letting admin_port + repl_slave can replay readonly database. Originally Reviewed By: yoshinorim fbshipit-source-id: b8fce06 commit 02d7ee4db7a16df45faf244c6854b3a51fb194a5 Author: Zhicheng Zhu <[email protected]> Date: Mon Sep 9 16:03:33 2019 -0700 let rpl_repl_slave_acl can use binlog Summary: Context: If we use SUPER_USER priv to replay binlog and write metadata to dst replicaset, SUPER_USER writing to read-only master can cause GTID not generated and therefore these events will not be replicated to slaves and will be ignored by promotion, causing a silent dataloss Fix: To fix this we extend REPL_SLAVE_ACL so that binlog can bypass it and run like SUPER_USER but without causing GTID not generated. Originally Reviewed By: yoshinorim fbshipit-source-id: 1a67821
inikep
force-pushed
the
FB8-rpl_repl_slave_acl
branch
from
8985947 to
b72408c
Compare
|
I moved |
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 11, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: 8e4765845c5 Reference Patch: e6a4851729b Reference Patch: cfd9b938f57 Pull Request resolved: #1091 Reviewed By: lth Differential Revision: D19525120 Pulled By: lth fbshipit-source-id: c2c496f
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 26, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lth Differential Revision: D19525120 Pulled By: lth fbshipit-source-id: c2c496f
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 26, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lth Differential Revision: D19525120 Pulled By: lth fbshipit-source-id: c2c496f
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 26, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lth Differential Revision: D19525120 Pulled By: lth fbshipit-source-id: c2c496f
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 27, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lth Differential Revision: D19525120 Pulled By: lth fbshipit-source-id: c2c496f
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 5, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lth Differential Revision: D19525120 Pulled By: lth fbshipit-source-id: c2c496f
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 7, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lth Differential Revision: D19525120 Pulled By: lth fbshipit-source-id: c2c496f
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lth Differential Revision: D19525120 Pulled By: lth fbshipit-source-id: c2c496f
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lth Differential Revision: D19525120 Pulled By: lth fbshipit-source-id: c2c496f
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lth Differential Revision: D19525120 Pulled By: lth fbshipit-source-id: c2c496f
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Nov 11, 2020
Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lth Differential Revision: D19525120 Pulled By: lth fbshipit-source-id: c2c496f
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 11, 2021
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 (facebook@89bc302) Pulled By: lth fbshipit-source-id: 62d50f608cc
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 3, 2021
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 (facebook@89bc302) Pulled By: lth fbshipit-source-id: 62d50f608cc
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2021
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 (facebook@89bc302) Pulled By: lth fbshipit-source-id: 62d50f608cc
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 (facebook@89bc302) Pulled By: lth fbshipit-source-id: 62d50f608cc
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 1, 2021
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 (facebook@89bc302) Pulled By: lth fbshipit-source-id: 62d50f608cc
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 2, 2021
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 (facebook@89bc302) Pulled By: lth fbshipit-source-id: 62d50f608cc
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 18, 2022
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 19, 2022
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 26, 2023
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2023
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 25, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 21, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 25, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 2, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
facebook#1091) Summary: Extend BINLOG_ADMIN to work with `ALTER DATABASE test read_only=True` so BINLOG_ADMIN will be equal to `REPLICATION SLAVE+ADMIN PORT` in 5.6. This patch replaces the following 5.6 commits: Extend repl_slave + admin_port to set gtid_next when repaly binlog let admin_port + repl_slave bypass read only database let rpl_repl_slave_acl can use binlog Reference Patch: facebook@8e4765845c5 Reference Patch: facebook@e6a4851729b Reference Patch: facebook@cfd9b938f57 Pull Request resolved: facebook#1091 Reviewed By: lloyd Differential Revision: D19525120 Pulled By: lth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Extend BINLOG_ADMIN to work with
ALTER DATABASE test read_only=Trueso BINLOG_ADMIN will be equal toREPLICATION SLAVE+ADMIN PORTin 5.6.This patch replaces the following 5.6 commits:
commit 2eeee2cad2786227213f248158738eb8470cba0f
Author: Zhicheng Zhu [email protected]
Date: Tue Oct 29 10:20:47 2019 -0700
commit 30f5d8f273609dd95245f0a6f3cf36fe8dda3726
Author: Zhicheng Zhu [email protected]
Date: Fri Sep 13 12:51:10 2019 -0700
commit 02d7ee4db7a16df45faf244c6854b3a51fb194a5
Author: Zhicheng Zhu [email protected]
Date: Mon Sep 9 16:03:33 2019 -0700