Fix counter leak in nonsuper_connections #1069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: If a non-super user connects to mysqld with an invalid database name, nonsuper_connections is incremented, but never decremented. Originally Reviewed By: yizhang82 fbshipit-source-id: a9083cc 8.0 porting notes: Since nonsuper_connections is already decremented by calling release_user_connection(), changes to the code are not needed. Test is ported though to make sure the leak won't appear again.
|
nonsuper_connections is incremented in mysql-5.6/sql/auth/sql_authentication.cc Line 3531 in 761c542 Then, as a requested database doesn't exist, release_user_connection() is called at mysql-5.6/sql/auth/sql_authentication.cc Line 3561 in 761c542 Line 282 in 761c542 |
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 30, 2019
Summary: If a non-super user connects to mysqld with an invalid database name, nonsuper_connections is incremented, but never decremented. Squash with D13987618 8.0 porting notes: Since nonsuper_connections is already decremented by calling release_user_connection(), changes to the code are not needed. Test is ported though to make sure the leak won't appear again. Reference Patch: 3cc5162fdc2 Pull Request resolved: #1069 Reviewed By: yizhang82 Differential Revision: D19129736 Pulled By: hermanlee fbshipit-source-id: 64a9117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If a non-super user connects to mysqld with an invalid database name,
nonsuper_connections is incremented, but never decremented.
Originally Reviewed By: yizhang82
fbshipit-source-id: a9083cc
8.0 porting notes:
Since nonsuper_connections is already decremented by calling
release_user_connection(), changes to the code are not needed. Test is
ported though to make sure the leak won't appear again.