Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new option to make MySQL server truncate binlogs during crash recovery. #1061

Closed
wants to merge 1 commit into from
Closed

Add a new option to make MySQL server truncate binlogs during crash recovery. #1061

wants to merge 1 commit into from

Conversation

percona-ysorokin
Copy link
Contributor

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:

  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Originally Reviewed By: abhinav04sharma

fbshipit-source-id: 6573e88

@bhatvinay @percona-ysorokin
Add a new option to make MySQL server truncate binlogs during crash r…
1d44cb6 
…ecovery.

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Originally Reviewed By: abhinav04sharma

fbshipit-source-id: 6573e88
@percona-ysorokin
Copy link
Contributor Author

Jenkins build link
https://fb.cd.percona.com/job/fb-mysql-server-8.0-param/84/
main.archive - a known regression
main.all_persisted_variables - a known regression (just needs to be updated/re-recorded)
rpl_nogtid.rpl_semi_sync_deadlock - a known regression (test case times out)

facebook-github-bot
facebook-github-bot reviewed Dec 4, 2019
View reviewed changes
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Dec 5, 2019
@bhatvinay @facebook-github-bot
Add a new option to make MySQL server truncate binlogs during crash r…
83017aa 
…ecovery. (#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: 96308865f3c

Originally Reviewed By: abhinav04sharma

Pull Request resolved: #1061

Test Plan: Build mysql

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay

fbshipit-source-id: 7d893fd
@hermanlee hermanlee closed this Dec 13, 2019
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jul 30, 2020
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
81c82cd 
…ecovery. (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Test Plan: Build mysql

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Aug 10, 2020
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
87ffd36 
…ecovery. (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Test Plan: Build mysql

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Aug 10, 2020
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
ac83733 
…ecovery. (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Test Plan: Build mysql

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Sep 7, 2020
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
df92e86 
…ecovery. (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Test Plan: Build mysql

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Sep 9, 2020
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
74de16b 
…ecovery. (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Test Plan: Build mysql

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Sep 9, 2020
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
a247957 
…ecovery. (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Test Plan: Build mysql

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Oct 5, 2020
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
c658dc1 
…ecovery. (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Test Plan: Build mysql

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Mar 11, 2021
@inikep @facebook-github-bot
Add a new option to make MySQL server truncate binlogs during crash r…
f533655 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324 (facebook@83017aa)

Pulled By: bhatvinay

fbshipit-source-id: 6801122e380
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jul 27, 2021
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
45b5979 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324 (facebook@83017aa)

Pulled By: bhatvinay

fbshipit-source-id: 6801122e380
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jul 28, 2021
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
bc3b824 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324 (facebook@83017aa)

Pulled By: bhatvinay

fbshipit-source-id: 6801122e380
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Sep 2, 2021
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
c92c9ee 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324 (facebook@83017aa)

Pulled By: bhatvinay

fbshipit-source-id: 6801122e380
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jan 17, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
7979f9d 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jan 17, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
1adefeb 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jan 18, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
9c5ebe2 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jan 19, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
d774c8a 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jan 20, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
ab37994 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jan 24, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
b2d1f58 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jan 28, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
0badcb2 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jan 28, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
ca1b14e 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Mar 7, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
25e3657 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Mar 11, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
d8b3b39 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Mar 14, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
e8114c4 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Mar 14, 2022
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
c3bf074 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jun 19, 2023
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
ffaf62a 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jun 23, 2023
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
afc4b37 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
hermanlee pushed a commit to hermanlee/mysql-5.6 that referenced this pull request Oct 3, 2023
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
dc88978 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
hermanlee pushed a commit to hermanlee/mysql-5.6 that referenced this pull request Oct 18, 2023
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
1750181 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Apr 23, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
c9c2087 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Apr 23, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
58ee0e8 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Apr 25, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
afa4d2b 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 7, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
7649060 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 8, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
2c0e5b7 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 9, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
bfaf7c7 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 10, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
712db42 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 13, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
8eff7ac 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 15, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
c769f73 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 16, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
ccaa393 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 17, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
17d7775 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 17, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
88ff690 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 21, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
f93f273 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 21, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
95c6558 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request May 30, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
8d84f0b 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jun 19, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
8d585c9 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jun 19, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
553a5fc 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jun 20, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
7a18e4f 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jun 21, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
fdcd13c 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jun 25, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
80b6c9b 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jul 2, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
13192f7 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jul 19, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
ba5be22 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jul 19, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
820c45d 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Jul 31, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
ee64899 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Aug 2, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
3403b45 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
inikep added a commit to inikep/mysql-5.6 that referenced this pull request Aug 6, 2024
@inikep
Add a new option to make MySQL server truncate binlogs during crash r…
26a3a94 
…ecovery. (facebook#1061) (facebook#1061)

Summary:
This diff adds a new option to trim binlog during recovery. The following happens if this option is set:
  1. All prepared trasnactions in the engine are rolled back during engine recovery
  2. The binlog file (which was marked 'IN USE') will be truncated to the position as reported by engine as the last commited gtid position in the binlog

Reference Patch: facebook@96308865f3c
Reference Patch: facebook@6288eda9d6e
Reference Patch: facebook@12937e8de06
Reference Patch: facebook@fe3826a6743

Originally Reviewed By: abhinav04sharma

Pull Request resolved: facebook#1061

Reviewed By: luqun

Differential Revision: D18812324

Pulled By: bhatvinay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@hermanlee hermanlee hermanlee approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@percona-ysorokin @facebook-github-bot @hermanlee @bhatvinay