-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertion `covers_key(b)' failed in int myrocks::Rdb_key_def::cmp_full_keys(const rocks db::Slice&, const rocksdb::Slice&) #728
Comments
@georgelorchpercona Yes, I think this check did not account for the code path where we calculate the successor key of the where conditional to position the iterator in the cases of find_flag = HA_READ_PREFIX_LAST_OR_PREV (or a couple others). In this case, the lookup key is the last key in the index: (e.g. 00 00 01 04 ff), so the successor key changes the four byte index_prefix: (e.g. 00 00 01 05 00). The calculation is correct, but the lookup key ends up being outside the range of the current index and triggers the failure. We'll need to change the assert when checking the lookup key. cc: @yoshinorim |
Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes #730 Differential Revision: D6053481 Pulled By: yoshinorim fbshipit-source-id: dc85b91
…book#728) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 GitHub Author: Yoshinori Matsunobu <[email protected]> Github PR Sync: {sync, type="child", parent="github", parentrepo="facebook/mysql-5.6", parentprnum="730", parentprfbid="130952380895779"} Test Plan: mtr Reviewers: generatedunixname499836121, svcscm Reviewed By: svcscm Subscribers: [email protected] Differential Revision: https://phabricator.intern.facebook.com/D6053481 Signature: 6053481:1508180303:9daea859dcb9216b7544390358eebd530a66b9b5
Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes #730 Test Plan: mtr Differential Revision: D6053481 Pulled By: yoshinorim fbshipit-source-id: 69344b9
…ook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Test Plan: mtr Differential Revision: D6053481 Pulled By: yoshinorim fbshipit-source-id: 69344b9
…ook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Test Plan: mtr Differential Revision: D6053481 Pulled By: yoshinorim fbshipit-source-id: 69344b9
…ook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Test Plan: mtr Differential Revision: D6053481 Pulled By: yoshinorim fbshipit-source-id: 69344b9
…ook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Test Plan: mtr Differential Revision: D6053481 Pulled By: yoshinorim fbshipit-source-id: 69344b9
…ook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Test Plan: mtr Differential Revision: D6053481 Pulled By: yoshinorim fbshipit-source-id: 69344b9
Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes #730 Differential Revision: D6053481 (1d01321) Pulled By: yoshinorim fbshipit-source-id: fc6d3f38b58
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 (facebook@1d01321) Pulled By: yoshinorim fbshipit-source-id: fc6d3f38b58
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 (facebook@1d01321) Pulled By: yoshinorim fbshipit-source-id: fc6d3f38b58
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 (facebook@1d01321) Pulled By: yoshinorim fbshipit-source-id: fc6d3f38b58
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 (facebook@1d01321) Pulled By: yoshinorim fbshipit-source-id: fc6d3f38b58
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 (facebook@1d01321) Pulled By: yoshinorim fbshipit-source-id: fc6d3f38b58
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 (facebook@1d01321) Pulled By: yoshinorim fbshipit-source-id: fc6d3f38b58
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 (facebook@1d01321) Pulled By: yoshinorim fbshipit-source-id: fc6d3f38b58
Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes #730 Differential Revision: D6053481 Pulled By: yoshinorim
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 Pulled By: yoshinorim
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 Pulled By: yoshinorim
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 Pulled By: yoshinorim
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 Pulled By: yoshinorim
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 Pulled By: yoshinorim
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 Pulled By: yoshinorim
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 Pulled By: yoshinorim
…ook#730) (facebook#730) Summary: This diff removes an extra assertion on covers_key(b). Prefix condition might be incremented by successor(). It may overflow and points to outside of the index_id. This is an expected behavior and it should not fail. Closes facebook#730 Differential Revision: D6053481 Pulled By: yoshinorim
Built on the fb-mysql-5.6.35/78909f9bfcee66cd85913f64546c5d91d27dd22c
This is a debug assertion, is this maybe another over aggressive debug assertion or potentially a real problem?
Very simple reproduction case, my.cnf :
And SQL :
And the bt full :
The text was updated successfully, but these errors were encountered: