fix: correctly format logs when saving bundle

[szymonrybczak]

Summary

When using community-cli-plugin, output when saving bundle looks like this:

❯ npx react-native bundle --platform android --entry-file index.js --dev=false --bundle-output dist/
                Welcome to Metro v0.80.9
              Fast - Scalable - Integrated

info Writing bundle output to:, dist/

There's a useless comma in log, because community-cli-plugin uses logger.info from @react-native-community/cli-tools which separates each item with , separator.

Test plan

Saving bundle output should contain correctly formatted log:

info Writing bundle output to: dist/

[szymonrybczak]

cc @huntie

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.80%. Comparing base (9b295e5) to head (6f86b48).

Files	Patch %	Lines
packages/metro/src/shared/output/bundle.flow.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1300   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files         207      207           
  Lines       10883    10883           
  Branches     2733     2733           
=======================================
  Hits         9121     9121           
  Misses       1762     1762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[huntie]

@szymonrybczak Hmm, can we drop this change? Rest looks good!

The interface here is that we expect a logger that is similar to console.log()'s API, which accepts multiple args that will be concatenated without a ,.

• Happy with the other changes, which make this behaviour the most predictable wherever Metro is integrated.
• I'd prefer an upstream alignment in @react-native-community/cli-tools to (...message: Array<string>) => void. Our current types in dev-middleware assume this: https://github.com/facebook/react-native/blob/c0b5e2e031f0e471b57640be13fe086d36c48a99/packages/dev-middleware/src/types/Logger.js#L12-L15.

[szymonrybczak]

Yeah, I'm good with deleting this change. We just need to be careful when adding more logging to check if they're correctly formatted 👍

[szymonrybczak]

Removed in 6f86b48

[facebook-github-bot]

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@huntie merged this pull request in 2f1801a.