stat() calls are missing warnings

[SiebelsTim]

PHP says to raise a warning on bad stat() calls in C
(https://github.com/php/php-src/blob/af6c11c5f060870d052a2b765dc634d9e47d0f18/ext/standard/filestat.c#L909)

PHP's manual agrees on this:
http://de3.php.net/manual/en/function.is-dir.php#refsect1-function.is-dir-errors (and many others)

However I could not get a warning on is_dir:
http://3v4l.org/kG9PX

Tried to fix with

diff --git a/hphp/runtime/ext/ext_file.cpp b/hphp/runtime/ext/ext_file.cpp
index 37c932c..411d014 100644
--- a/hphp/runtime/ext/ext_file.cpp
+++ b/hphp/runtime/ext/ext_file.cpp
@@ -156,6 +156,7 @@ static int statSyscall(
     std::string realpath = StatCache::realpath(fullpath.data());
     // realpath will return an empty string for nonexistent files
     if (realpath.empty()) {
+      raise_warning("stat failed for %s", path.c_str());
       return ENOENT;
     }
     auto translatedPath = canUseFileCache ?

[paulbiss]

Looks like there had been a (now abandoned) PR for this. @JoelMarcey are you looking into it?

[SiebelsTim]

@paulbiss Do you mean my PR #3000? That was only related to it, not fixing this.

[paulbiss]

Ah, okay.

[Majkl578]

However I could not get a warning on is_dir

Because is_dir is a testing function, it should not throw warnings if target does not exist. Even your 3v4l snippet does not throw a warning in PHP.