Skip to content

Reflection classes should have a __clone method #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stof opened this issue Jan 15, 2014 · 2 comments
Closed

Reflection classes should have a __clone method #1572

stof opened this issue Jan 15, 2014 · 2 comments
Assignees
@LiraNuna
Labels
php5 incompatibility

Comments

@stof
Copy link
Contributor

stof commented Jan 15, 2014

The __clone method is undocumented, but it exists, preventing cloning: http://3v4l.org/0qc1t

It is also the case for other classes from Reflection: http://3v4l.org/ah7om
@scannell
Copy link
Contributor

Thanks for reporting this. Feel free to submit a PR if you (or someone else reading this) get to this before we do.

stof added a commit to stof/prophecy that referenced this issue Jan 15, 2014
@stof
Fixed the spec checking for private method on HHVM
7b1c203 
HHVM does not yet define the private __clone method on ReflectionClass, so
the spec was failing. The HHVM incompatibility has been reported as
facebook/hhvm#1572
@stof stof mentioned this issue Jan 15, 2014
Merged
thekid added a commit to thekid/hhvm that referenced this issue Jan 19, 2014
@thekid
Implement __clone() for all reflection classes
0a32b06 
Fixes facebook#1572
Note: Behaves differently than PHP which fatals, using BadMethodCallException
here in alignment with "fatal error: call to a method of a non-object"
@thekid thekid mentioned this issue Jan 19, 2014
Closed
@LiraNuna
Copy link
Contributor

Oops, seems like this wasn't merged. Reopening.

@LiraNuna LiraNuna reopened this May 16, 2014
@LiraNuna LiraNuna added this to the Lockdown milestone May 16, 2014
@LiraNuna LiraNuna self-assigned this May 16, 2014
@LiraNuna LiraNuna removed the mid-pri label May 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LiraNuna LiraNuna

Labels
php5 incompatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LiraNuna @stof @scannell